Skip to content

Commit

Permalink
Fix comment missing a dash for argument name (open-telemetry#31160)
Browse files Browse the repository at this point in the history
  • Loading branch information
atoulme committed Feb 9, 2024
1 parent 8ee5efc commit 22e0ce0
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion cmd/telemetrygen/internal/common/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ func (c *Config) CommonFlags(fs *pflag.FlagSet) {
c.ResourceAttributes = make(map[string]string)
fs.Var(&c.ResourceAttributes, "otlp-attributes", "Custom resource attributes to use. The value is expected in the format key=\"value\"."+
"Note you may need to escape the quotes when using the tool from a cli."+
"Flag may be repeated to set multiple attributes (e.g -otlp-attributes key1=\"value1\" -otlp-attributes key2=\"value2\")")
"Flag may be repeated to set multiple attributes (e.g --otlp-attributes key1=\"value1\" --otlp-attributes key2=\"value2\")")

c.TelemetryAttributes = make(map[string]string)
fs.Var(&c.TelemetryAttributes, "telemetry-attributes", "Custom telemetry attributes to use. The value is expected in the format \"key=\\\"value\\\"\". "+
Expand Down
2 changes: 1 addition & 1 deletion cmd/telemetrygen/internal/traces/traces.go
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ func Start(cfg *Config) error {
}

var attributes []attribute.KeyValue
// may be overridden by `-otlp-attributes service.name="foo"`
// may be overridden by `--otlp-attributes service.name="foo"`
attributes = append(attributes, semconv.ServiceNameKey.String(cfg.ServiceName))
attributes = append(attributes, cfg.GetAttributes()...)

Expand Down

0 comments on commit 22e0ce0

Please sign in to comment.