Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip waiting for MongoDB if not installed or configured. #39

Closed
wants to merge 1 commit into from
Closed

Skip waiting for MongoDB if not installed or configured. #39

wants to merge 1 commit into from

Conversation

abernix
Copy link

@abernix abernix commented Apr 3, 2020

MongoDB is no longer an absolute requirement of all Meteor applications and can be optionally removed.

This adds a guard that skips the polling and waiting for Mongo to become available if either the 'mongodb' module is not present, or if the 'MONGO_URL' environment variable
is unset.

Full-disclosure, I coded this entirely in the GitHub editor, but I suspect it should
work well. I'm not sure the best way to test this from the checkout though. 😉

MongoDB is no longer an absolute requirement of all Meteor
applications and can be optionally removed.

This adds a guard that skips the polling and waiting for
Mongo to become available if either the 'mongodb' module
is not present, or if the 'MONGO_URL' environment variable
is unset.
@GeoffreyBooth
Copy link
Collaborator

MongoDB is no longer an absolute requirement of all Meteor applications and can be optionally removed.

Do you have a citation for this?

I'm working on a refactor that splits entrypoint.sh into several scripts, so that the child scripts can be overridden without needing to override everything. As part of that, I’ll update the “check Mongo” script so that it’s only run if MONGO_URL is set. I think that's a good way to control it. This refactor also adds tests.

@abernix
Copy link
Author

abernix commented Apr 22, 2020

It became possible some time before the introduction of the --minimal flag in Meteor 1.7, but was very much made simpler by the flag itself:

@abernix
Copy link
Author

abernix commented Apr 22, 2020

Your plan sounds great, and leveraging MONGO_URL is probably more than sufficient, so feel free to close this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants