Skip to content
This repository has been archived by the owner on Jul 12, 2023. It is now read-only.

fix(esm): resolve esm imports #229

Merged
merged 3 commits into from
Nov 11, 2021
Merged

fix(esm): resolve esm imports #229

merged 3 commits into from
Nov 11, 2021

Conversation

vijayymmeena
Copy link

Please describe the changes this PR makes and why it should be merged:

fixes #227

@codecov
Copy link

codecov bot commented Nov 10, 2021

Codecov Report

Merging #229 (8718a12) into main (df656f8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #229   +/-   ##
=======================================
  Coverage   73.65%   73.65%           
=======================================
  Files          21       21           
  Lines         911      911           
  Branches      227      227           
=======================================
  Hits          671      671           
  Misses        238      238           
  Partials        2        2           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df656f8...8718a12. Read the comment docs.

@vijayymmeena
Copy link
Author

Request for workflow approval, it is fixed now.

image

@vijayymmeena
Copy link
Author

image

lib detected, hence issue will be fixed (tested). Just wait for final commit.

@vijayymmeena
Copy link
Author

image

lib detected, hence issue will be fixed (tested). Just wait for final commit.

ready 👍

@iCrawl
Copy link
Member

iCrawl commented Nov 11, 2021

Thanks!

I was about to do this myself but haven't had the time yet after I asked for the banner option to be added to tsup 👍

@iCrawl iCrawl changed the title fix(esm): fixes #227 fix(esm): resolve esm imports Nov 11, 2021
@iCrawl iCrawl merged commit 616f2bc into discordjs:main Nov 11, 2021
@vijayymmeena vijayymmeena deleted the patch branch November 11, 2021 05:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doesn't find libraries when using ES modules
2 participants