When setting scrollable, keep isScrollableLocked value if scrollable is scrolling #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huderlem
approved these changes
Feb 5, 2024
| @@ -19,6 +19,7 @@ export const useScrollable = () => { | |||
| ); | |||
| const isScrollableRefreshable = useSharedValue<boolean>(false); | |||
| const isScrollableLocked = useSharedValue<boolean>(true); | |||
| const isScrollEnded = useSharedValue<boolean>(true); | |||
There was a problem hiding this comment.
Before this PR, isScrollEnded was initialized to false, but now it's initialized to true. It seems to make more sense as true, but I'm worried that might cause some issues with the existing code unrelated to the isScrollableLocked logic.
There was a problem hiding this comment.
it's only used in scroll handlers and being set on drag begins, so I think the initial value doesn't really matter here https://github.com/discord/react-native-bottom-sheet/blob/discord-fork-4.5.1/src/hooks/useScrollEventsHandlersDefault.ts#L106
yayvery
pushed a commit
that referenced
this pull request
Feb 24, 2024
yayvery
pushed a commit
that referenced
this pull request
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide enough information so that others can review your pull request:
I added
isScrollEndedin bottom sheet internal state. So when setting scrollable, we can keepisScrollableLockedif scrollable is still scrolling. It's possible that scrollable is updated when it's being scrolled, in this case we shouldn't interrupt the lockable state.