Merge pull request #4 from waxandwane/fix/focus-ring-with-targets

fix(focusringcontext): invalidate after context mutation thru showElement()
discord · Mar 4, 2021 · 3649ec4 · 3649ec4
2 parents 2b1c742 + 1d9c033
commit 3649ec4
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/FocusRingContext.tsx b/src/FocusRingContext.tsx
@@ -40,24 +40,24 @@ export class FocusRingContextManager {
  }
 
  showElement(element: Element, opts: FocusRingShowOpts = {}) {
- this.invalidate();
  this.targetElement = element;
  this.targetAncestry = this.getElementAncestors(this.targetElement);
  this.boundingBox = undefined;
  this.className = opts.className;
  this.offset = opts.offset ?? 0;
  this.zIndex = opts.zIndex;
  setActiveRingContextManager(this);
+ this.invalidate();
  }
 
  hide() {
- this.invalidate();
  this.targetElement = undefined;
  this.targetAncestry = undefined;
  this.boundingBox = undefined;
  this.className = undefined;
  this.offset = 0;
  this.zIndex = undefined;
+ this.invalidate();
  }
 
  get visible() {