-
-
Notifications
You must be signed in to change notification settings - Fork 728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add interaction related message flags #1790
Add interaction related message flags #1790
Conversation
…s' into feature/add-missing-message-flags
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think methods such as addReaction
, pin
, and editMessage
should check for this flag and throw an exception. You can't use these methods on ephemeral messages since you get an unknown message error response.
src/main/java/net/dv8tion/jda/internal/entities/ReceivedMessage.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Florian Spieß <[email protected]>
Co-authored-by: Florian Spieß <[email protected]>
Co-authored-by: Florian Spieß <[email protected]>
Co-authored-by: Florian Spieß <[email protected]>
…s' into feature/add-missing-message-flags
…e.java Co-authored-by: Florian Spieß <[email protected]>
src/main/java/net/dv8tion/jda/internal/entities/ReceivedMessage.java
Outdated
Show resolved
Hide resolved
src/main/java/net/dv8tion/jda/internal/entities/ReceivedMessage.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You likely need to update the throws docs on these methods to reflect the behavior on ephemeral messages
src/main/java/net/dv8tion/jda/internal/entities/ReceivedMessage.java
Outdated
Show resolved
Hide resolved
src/main/java/net/dv8tion/jda/internal/entities/ReceivedMessage.java
Outdated
Show resolved
Hide resolved
src/main/java/net/dv8tion/jda/internal/entities/ReceivedMessage.java
Outdated
Show resolved
Hide resolved
src/main/java/net/dv8tion/jda/internal/entities/ReceivedMessage.java
Outdated
Show resolved
Hide resolved
src/main/java/net/dv8tion/jda/internal/entities/ReceivedMessage.java
Outdated
Show resolved
Hide resolved
…e.java Co-authored-by: Florian Spieß <[email protected]>
…e.java Co-authored-by: Florian Spieß <[email protected]>
…e.java Co-authored-by: Florian Spieß <[email protected]>
Pull Request Etiquette
Changes
Closes Issue: NaN
Description
This adds the EPHEMERAL and LOADING message flags, the ephemeral flag is particularly useful as you can't determine if a message is ephemeral by checking if
GenericComponentInteractionEvent#getMessage
isnull
Also fixes docs for ComponentInteraction#getMessage and enables
editButton
andeditSelectionMenu
methods