Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix outdated sticker field name #1732

Merged

Conversation

Andre601
Copy link
Contributor

Pull Request Etiquette

Changes

  • Internal code
  • Library interface (affecting end-user code)
  • Documentation
  • Other: _____

Closes Issue: #1731

Description

Updated stickers to sticker_items in the EntityBuilder

@MinnDevelopment
Copy link
Member

This needs to adjust the documentation on Message#getStickers to state that these stickers are partial, and limited to just the necessary information to render it. This means you only get the id, format type, and name.


Unrelated to this pull request:

I noticed that, when sending a message, you still receive the stickers array in addition to sticker_items. Although, this is deprecated so we can probably just ignore it.

Another thing, the guild object might also contain rich sticker objects, which we could potentially add support for if discord would document it. There also is a GET/stickers/:sticker_id/guild endpoint that seems to be undocumented as well.

@Andre601
Copy link
Contributor Author

This needs to adjust the documentation on Message#getStickers to state that these stickers are partial, and limited to just the necessary information to render it. This means you only get the id, format type, and name.

Adressed this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants