Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: close tmp file #1272

Merged
merged 1 commit into from
Jun 19, 2024
Merged

fix: close tmp file #1272

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions internal/cmd/cmd_fetchurl.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ func cmdFetchURL(_ Env, args []string, config *Config) (err error) {
return err
}
defer os.Remove(tmpfile.Name()) // clean up
defer tmpfile.Close()

// Get the URL
// G107: Potential HTTP request made with variable url
Expand Down Expand Up @@ -104,6 +105,10 @@ func cmdFetchURL(_ Env, args []string, config *Config) (err error) {

// Put the file into the CAS store if it's not already there
if !fileExists(casFile) {
err = tmpfile.Close()
if err != nil {
return err
}
// Move the temporary file to the CAS location.
if err = os.Rename(tmpfile.Name(), casFile); err != nil {
return err
Expand Down