Skip to content

Commit

Permalink
fix: close tmp file
Browse files Browse the repository at this point in the history
Signed-off-by: guoguangwu <[email protected]>
  • Loading branch information
testwill committed Apr 16, 2024
1 parent 6a73cc2 commit 9c5663b
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions internal/cmd/cmd_fetchurl.go
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ func cmdFetchURL(_ Env, args []string, config *Config) (err error) {
return err
}
defer os.Remove(tmpfile.Name()) // clean up
defer tmpfile.Close()

// Get the URL
// G107: Potential HTTP request made with variable url
Expand Down Expand Up @@ -104,6 +105,10 @@ func cmdFetchURL(_ Env, args []string, config *Config) (err error) {

// Put the file into the CAS store if it's not already there
if !fileExists(casFile) {
err = tmpfile.Close()
if err != nil {
return err
}
// Move the temporary file to the CAS location.
if err = os.Rename(tmpfile.Name(), casFile); err != nil {
return err
Expand Down

0 comments on commit 9c5663b

Please sign in to comment.