utils: fix rounding functions #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Standard MathMod() function may return not-so-correct results so it cannot be relied upon when rounding. For example, MathMod(0.6,0.1) yields 0.099999.. which may be deceiving. This caveat makes rounding completely incorrect with current logic. Use MathRound() instead. Changes: * modify roundUpToMultiple/roundDownToMultiple to use MathRound(); * add roundUpToStep/roundDownToStep functions calculating value with regard to a minimum value and a step. New functions are useful to calculate correct lots with SYMBOL_VOLUME_MIN/SYMBOL_VOLUME_STEP. Signed-off-by: Yerden Zhumabekov <[email protected]>
dingmaotu
approved these changes
Apr 9, 2018
|
Floating point computations are not so straightforward due to hardware limitations. This is really a thing to keep an eye on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standard MathMod() function may return not-so-correct results
so it cannot be relied upon when rounding. For example,
MathMod(0.6,0.1) yields 0.099999.. which may be deceiving.
This caveat makes rounding completely incorrect with current
logic. Use MathRound() instead.
Changes:
with regard to a minimum value and a step.
New functions are useful to calculate correct lots with
SYMBOL_VOLUME_MIN/SYMBOL_VOLUME_STEP.
Big diff is MetaEditor Styler's fault, not mine 😄