-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding all Currencies to also have Currency<bigint> #582
base: main
Are you sure you want to change the base?
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/dinerojs/dinerojs/3HYVDrhLGRSPmYLT9TQLJ7HoFCV2 |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 03e3b1f:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, adding BigInt currencies makes sense. Though for packaging as an umd, separating the number
and BigInt
currencies seems like a better idea to me, just like the calculators.
Yes, creating two packages in the same fashion as the calculators seems like the right way to go. |
I just created PR #665 it moves the currencies packages to currencies-number. If @sarahdayan thinks this is the way forward, @reckter could you modify this PR to create a new currencies-bigint package? Also just a though, to avoid duplication, would making a script to generate the currency files be a better approach? All the data could be in a single json file. |
@johnhooks Totally agree that we should generate the currencies. The |
@johnhooks Looking at #670, it should be fairly trivial with that to implement this PR, so will look into that after it has been merged. (Feel free to just go ahead yourself, If I take to long 😅 ). Thanks for picking this up again 🍺 ! |
Sounds good! |
Adding an additional
168-bigint
to theamendments
folder. that contain all currencies inCurrency<bigint>
format.I am not sure wether this is the right place or even way of doing it, but as they are currently missing, I thought providing one proposal on how to solve this might be a good idea.
Let me know your thoughts on this, happy to move the folder / or do something completely different :)