Use std::hint::black_box consistently. #1273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also removes the `#![feature(bench_black_box)]`. This was stabilized in Rust 1.66 and anyone building benchmarks will be on that or later (as they previously would have been on nightly). This also allows building `cargo build --all-targets` on stable Rust as it no longer dies when hitting the feature addition in the benchmarks.
8b1cedb
to
9042d14
Compare
|
Thanks, this will be a very useful change. I'm not entirely sure about merging this right away, as this means that we cannot run benchmarks against older Rust versions (despite needing nightly, we could use an old version). I'm not sure how relevant this is though - @sebcrozet do you have any opinions on this? My feeling is that we should probably just merge this, since I don't think we'll need to consider performance pre 1.66 anyway, but I don't have a full overview of use cases, especially with respect to the CUDA work etc. |
|
Hmm, are benchmarks even built in CI...? 🤔 |
|
Thanks! Merging this should be fine. The CUDA version won’t attempt to compile/run benchmarks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also removes the
#![feature(bench_black_box)]. This was stabilized in Rust 1.66 and anyone building benchmarks will be on that or later (as they previously would have been on nightly).This also allows building
cargo build --all-targetson stable Rust as it no longer dies when hitting the feature addition in the benchmarks.