forked from appsmithorg/appsmith
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pull] release from appsmithorg:release #47
Open
pull
wants to merge
1,909
commits into
digitty-forks:release
Choose a base branch
from
appsmithorg:release
base: release
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…4312) ## Description - Remove headless radio and use react-aria component instead - Create ErrorMessage component Fixes #27677 ## Automation /ok-to-test tags="@tag.Anvil" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9567388261> > Commit: 62d1153caa8bf03d827f88593c9dfaf3121091ee > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9567388261&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Anvil` <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Added `ErrorMessage` component for displaying error messages with specific styling. - Introduced `isDisabled` prop for `Label` and `ToggleGroup` components. - Updated `RadioGroup` to accept an items array for easier configuration. - **Bug Fixes** - Improved conditional rendering in `Label` component to prevent issues when `text` and `contextualHelp` are both falsy. - **Refactor** - Removed `Radio` component export from design system. - Restructured import statements and prop declarations for `Checkbox` and `RadioGroup`. - **Style** - Updated styles for `RadioGroup` and `ToggleGroup` components for better state handling (disabled, hovered, selected). - **Documentation** - Updated Storybook stories for `RadioGroup` to reflect changes in component usage. - **Tests** - Adjusted `RadioGroup.test.tsx` to test new items array prop. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
This temporary change is no longer needed. **/test sanity** <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9574310795> > Commit: abad77f > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9574310795&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Sanity` <!-- end of auto-generated comment: Cypress test results --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Chores** - Improved the startup script by removing obsolete PATH modification for PostgreSQL. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Follow up to #34281. The `.findById` method is now removed. No conflicts, but needs extra changes in [this PR](appsmithorg/appsmith-ee#4482) for build to pass on EE. **/test sanity** <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9563607766> > Commit: 02f6031 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9563607766&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Sanity` <!-- end of auto-generated comment: Cypress test results --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Refactor** - Updated methods to use direct values instead of `Optional` for permissions, simplifying method signatures and improving readability. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
The microservices that run inside the Appsmith container, trust each other, and may expose sensitive API endpoints to other internal microservices. These sensitive APIs aren't accessible by outside the Appsmith container, protected by Caddy's routing. This means that the backend server's ability to make user-configured HTTP requests, can lead to SSRFs to such sensitive API calls, if it's allowed to call APIs on localhost. In other words, Caddy establishes a trust boundary that protects these internal APIs from outside the container. But we lack such a trust boundary for the backend's plugins (API plugin, Elasticsearch plugin, etc.). This PR solves that. In this PR, we block both IPv4 and IPv6 loopback addresses. No additional changes needed on EE, no conflicts, and all unit and Cypress tests pass. **/test all** <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9590358198> > Commit: 5445c70 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9590358198&attempt=2" target="_blank">Cypress dashboard</a>. > Tags: `` <!-- end of auto-generated comment: Cypress test results --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Improved handling of disallowed hosts by dynamically computing based on environment variables, offering more flexibility and control. - **Refactor** - Enhanced the `makeWebClient()` method to use a more efficient approach for creating WebClient objects with custom configurations. - **Chores** - Added an `ENV` declaration for `IN_DOCKER` in the Dockerfile to better manage Docker-specific configurations. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Fixes #21790 _or_ Fixes [Issue URL](#21790) Introduced a new prop called isFullWidth for the CheckboxComponent and pass this prop to this styled component CheckboxContainer. The isFullWidth is an optional boolean property whole default value would be true. Added screenshot for reference. ![image](https://github.com/appsmithorg/appsmith/assets/119920490/1e5f3a9c-d98a-4525-85bc-8f6f471435ed) <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced a full-width option for checkboxes to enable better styling flexibility. - **Tests** - Added new test cases to verify checkbox styling properties in tables. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
## Description Moved `Back to all apps` from dropdown menu directly to header. Additionally renamed `NavigationMenuData.ts` to `useNavigationMenuData.ts` and fixed dependency related memoization issues. <img width="267" alt="image" src="https://github.com/appsmithorg/appsmith/assets/173164/020abfe3-1359-43ff-aa99-972a45f270bd"> Fixes #32982 ## Automation /ok-to-test tags="@tag.IDE" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9567752111> > Commit: 824b2fe > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9567752111&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.IDE` <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Refactor** - Removed `getNavigationMenu` prop from `EditorHeader` for streamlined navigation menu data retrieval. - Updated `EditorName` to use `useNavigationMenuData` for navigation menu items. - Refactored `useNavigationMenuData` to use `useCallback` and `useMemo` for enhanced performance. - Adjusted imports and event handling functions in `IDE/Header` to use `useCallback` for better efficiency. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
## Description Adds ESLint rule `react-hooks/exhaustive-deps` with warn level. Context in the task below. Fixes #34337 ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9584250724> > Commit: daa7050 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9584250724&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `` <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Chores** - Added ESLint rule `react-hooks/exhaustive-deps` with a severity level of "warn" to enforce exhaustive dependencies in React hooks. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
## Description PR to fix refreshing feature flags when instance fails to fetch flags from CS. ## Automation /ok-to-test tags="@tag.Sanity" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9563924054> > Commit: 9278bb3 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9563924054&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Sanity` <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Bug Fixes** - Improved feature flag updates by ensuring cached tenant features are evicted before updating, preventing potential stale data issues. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
## Description The purpose of this PR is to collect data about hovered canvas and widgets and send it to analytics platform. Fixes #33159 ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9584384829> > Commit: 9cec247 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9584384829&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `` <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced analytics tracking for side-by-side hover actions in the IDE canvas. - Added a new `AnalyticsWrapper` component for handling analytics events within layout systems. - Implemented a custom hook `useIsInSideBySideEditor` to check for side-by-side editor mode. - Added new CSS styles for layout systems. - **Bug Fixes** - Improved handling of widget hover events and analytics tracking in side-by-side editor mode. - **Refactor** - Refactored logic for determining the current entity info and segment state in the IDE. - Updated import paths and reordered imports for better organization. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
## Description ci-test-limit runs 3 machines by default and this is wastage of our resource, in most of our use cases we end up using only one machine soremoving extra unnecessary two. run - https://github.com/appsmithorg/appsmith/actions/runs/9593828953/job/26455099156 Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.Sanity" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9594698568> > Commit: 18d2ab3 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9594698568&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Sanity` <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Chores** - Updated test workflow configuration for more efficient CI runs. - **Tests** - Switched limited test spec file to improve test coverage and relevance. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Bumps [tinymce](https://github.com/tinymce/tinymce/tree/HEAD/modules/tinymce) from 7.0.0 to 7.2.0. ## Automation /ok-to-test tags="@tag.Sanity" <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/tinymce/tinymce/blob/main/modules/tinymce/CHANGELOG.md">tinymce's changelog</a>.</em></p> <blockquote> <h2>7.2.0 - 2024-06-19</h2> <h3>Added</h3> <ul> <li>Added <code>options.debug</code> API that logs the initial raw editor options to console. #TINY-10605</li> <li>Added <code>referrerpolicy</code> as a valid attribute for an iframe element. #TINY-10374</li> <li>New <code>onInit</code> and <code>stretched</code> properties to the <code>HtmlPanel</code> dialog component. #TINY-10900</li> <li>Added support for querying the state of the <code>mceTogglePlainTextPaste</code> command. #TINY-10938</li> <li>Added <code>for</code> option to dialog label components to improve accessibility. The value must be another component on the same dialog. #TINY-10971</li> </ul> <h3>Improved</h3> <ul> <li>Dialog slider components now emit an onChange event when using arrow keys. #TINY-10428</li> <li>Accessibility for element path buttons, added tooltip to describe the button and removed incorrect <code>aria-level</code> attribute. #TINY-10891</li> <li>Improve merging of inserted inline elements by removing nodes with redundant inheritable styles. #TINY-10869</li> <li>Improved Find & Replace dialog accessibility by changing placeholders to labels. #TINY-10871</li> </ul> <h3>Changed</h3> <ul> <li>Replaced tiny branding logo with <code>Build with TinyMCE</code> text and logo. #TINY-11001</li> </ul> <h3>Fixed</h3> <ul> <li>Deleting in a <code>div</code> with preceeding <code>br</code> elements would sometimes throw errors. #TINY-10840</li> <li><code>autoresize_bottom_margin</code> was not reliably applied in some situations. #TINY-10793</li> <li>Fixed cases where adding a newline around a br, table or img would not move the cursor to a new line. #TINY-10384</li> <li>Focusing on <code>contenteditable="true"</code> element when using <code>editable_root: false</code> and inline mode causing selection to be shifted. #TINY-10820</li> <li>Corrected the <code>role</code> attribute on listbox dialog components to <code>combobox</code> when there are no nested menu items. #TINY-10807</li> <li>HTML entities that were double decoded in <code>noscript</code> elements caused an XSS vulnerability. #TINY-11019</li> <li>It was possible to inject XSS HTML that was not matching the regexp when using the <code>noneditable_regexp</code> option. #TINY-11022</li> </ul> <h2>7.1.2 - 2024-06-05</h2> <h3>Fixed</h3> <ul> <li>CSS color values set to <code>transparent</code> were incorrectly converted to '<a href="https://github.com/tinymce/tinymce/tree/HEAD/modules/tinymce/issues/000000">#000000</a>`. #TINY-10916</li> </ul> <h2>7.1.1 - 2024-05-22</h2> <h3>Fixed</h3> <ul> <li>Insert/Edit image dialog lost focus after the image upload completed. #TINY-10885</li> <li>Deleting into a list from a paragraph that has an <code>img</code> tag could cause extra inline styles to be added. #TINY-10892</li> <li>Resolved an issue where emojis configured with the <code>emojiimages</code> database were not loading correctly due to a broken CDN. #TINY-10878</li> <li>Iframes in dialogs were not rendering rounded borders correctly. #TINY-10901</li> <li>Autocompleter possible values are no longer capped at a length of 10. #TINY-10942</li> </ul> <h2>7.1.0 - 2024-05-08</h2> <h3>Added</h3> <ul> <li>Parser support for math elements. #TINY-10809</li> <li>New <code>math-equation</code> icon. #TINY-10804</li> </ul> <h3>Improved</h3> <ul> <li>Included <code>itemprop</code>, <code>itemscope</code> and <code>itemtype</code> as valid HTML5 attributes in the core schema. #TINY-9932</li> <li>Notification accessibility improvements: added tooltips, keyboard navigation and shortcut to focus on notifications. #TINY-6925</li> </ul> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/tinymce/tinymce/commit/754e390c678c0decb9db459a2debccadfe4d2cd3"><code>754e390</code></a> TINY-10860: Prepare for 7.2 release (<a href="https://github.com/tinymce/tinymce/tree/HEAD/modules/tinymce/issues/9715">#9715</a>)</li> <li><a href="https://github.com/tinymce/tinymce/commit/a9fb858509f86dacfa8b01cfd34653b408983ac0"><code>a9fb858</code></a> TINY-11019 & TINY-11022: Fixed issues with noscript encoding and noneditable_...</li> <li><a href="https://github.com/tinymce/tinymce/commit/3fae00c85dd3c664c5b7437b0e6ded5514f6cca4"><code>3fae00c</code></a> TINY-10807: Use role="combobox" for flat ListBox components (<a href="https://github.com/tinymce/tinymce/tree/HEAD/modules/tinymce/issues/9665">#9665</a>)</li> <li><a href="https://github.com/tinymce/tinymce/commit/e7ef3b66e2398b1fbfaa98e80ce4986bf5776cab"><code>e7ef3b6</code></a> TINY-10871: replace placeholders with labels in Find & Replace dialog (<a href="https://github.com/tinymce/tinymce/tree/HEAD/modules/tinymce/issues/9689">#9689</a>)</li> <li><a href="https://github.com/tinymce/tinymce/commit/6ce11b686013036b58df187a60573146ab33d2d4"><code>6ce11b6</code></a> TINY-10936: Merge release to main (<a href="https://github.com/tinymce/tinymce/tree/HEAD/modules/tinymce/issues/9685">#9685</a>)</li> <li><a href="https://github.com/tinymce/tinymce/commit/5fa376a63e1d5b6c4de622684c93d4a902cfaa76"><code>5fa376a</code></a> TINY-11001: Replaced tiny branding logo (<a href="https://github.com/tinymce/tinymce/tree/HEAD/modules/tinymce/issues/9683">#9683</a>)</li> <li><a href="https://github.com/tinymce/tinymce/commit/c42efc2871268a7887bd72e0098ef065685e5283"><code>c42efc2</code></a> TINY-10938: Added query command for paste as plaintext status. (<a href="https://github.com/tinymce/tinymce/tree/HEAD/modules/tinymce/issues/9651">#9651</a>)</li> <li><a href="https://github.com/tinymce/tinymce/commit/70cff122d87c9937d93d1012f498d24b7d83bb62"><code>70cff12</code></a> TINY-10971: introduce optional label for property (<a href="https://github.com/tinymce/tinymce/tree/HEAD/modules/tinymce/issues/9681">#9681</a>)</li> <li><a href="https://github.com/tinymce/tinymce/commit/054671e930597a1edf45994132c97b72b163514a"><code>054671e</code></a> TINY-10891: Add tooltips to element path (<a href="https://github.com/tinymce/tinymce/tree/HEAD/modules/tinymce/issues/9676">#9676</a>)</li> <li><a href="https://github.com/tinymce/tinymce/commit/465fbbee67ca604d10e9ef5c63f80b2266156152"><code>465fbbe</code></a> TINY-10869: Improve merging inserted nested inline elements (<a href="https://github.com/tinymce/tinymce/tree/HEAD/modules/tinymce/issues/9658">#9658</a>)</li> <li>Additional commits viewable in <a href="https://github.com/tinymce/tinymce/commits/7.2.0/modules/tinymce">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=tinymce&package-manager=npm_and_yarn&previous-version=7.0.0&new-version=7.2.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/appsmithorg/appsmith/network/alerts). </details> <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9591867087> > Commit: f7d533f > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9591867087&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Sanity` <!-- end of auto-generated comment: Cypress test results --> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [socket.io](https://github.com/socketio/socket.io) from 4.6.1 to 4.6.2. ## Automation /ok-to-test tags="@tag.Sanity" <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/socketio/socket.io/releases">socket.io's releases</a>.</em></p> <blockquote> <h2>4.6.2</h2> <h3>Bug Fixes</h3> <ul> <li><strong>exports:</strong> move <code>types</code> condition to the top (<a href="https://redirect.github.com/socketio/socket.io/issues/4698">#4698</a>) (<a href="https://github.com/socketio/socket.io/commit/3d44aae381af38349fdb808d510d9f47a0c2507e">3d44aae</a>)</li> </ul> <h4>Links</h4> <ul> <li>Diff: <a href="https://github.com/socketio/socket.io/compare/4.6.1...4.6.2">https://github.com/socketio/socket.io/compare/4.6.1...4.6.2</a></li> <li>Client release: <a href="https://github.com/socketio/socket.io-client/releases/tag/4.6.2">4.6.2</a></li> <li><a href="https://github.com/socketio/engine.io/releases/tag/6.4.2"><code>engine.io@~6.4.2</code></a> (<a href="https://github.com/socketio/engine.io/compare/6.4.1...6.4.2">diff</a>)</li> <li><a href="https://github.com/websockets/ws/releases/tag/8.11.0"><code>ws@~8.11.0</code></a> (no change)</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/socketio/socket.io/blob/main/CHANGELOG.md">socket.io's changelog</a>.</em></p> <blockquote> <h2><a href="https://github.com/socketio/socket.io/compare/4.6.1...4.6.2">4.6.2</a> (2023-05-31)</h2> <h3>Bug Fixes</h3> <ul> <li><strong>exports:</strong> move <code>types</code> condition to the top (<a href="https://redirect.github.com/socketio/socket.io/issues/4698">#4698</a>) (<a href="https://github.com/socketio/socket.io/commit/3d44aae381af38349fdb808d510d9f47a0c2507e">3d44aae</a>)</li> </ul> <h3>Dependencies</h3> <ul> <li><a href="https://github.com/socketio/engine.io/releases/tag/6.4.0"><code>engine.io@~6.4.2</code></a> (<a href="https://github.com/socketio/engine.io/compare/6.4.1...6.4.2">diff</a>)</li> <li><a href="https://github.com/websockets/ws/releases/tag/8.11.0"><code>ws@~8.11.0</code></a> (no change)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/socketio/socket.io/commit/faf914c9ab3e06a6e84fc91774a4182e58f8ae70"><code>faf914c</code></a> chore(release): 4.6.2</li> <li><a href="https://github.com/socketio/socket.io/commit/15af22fc22bc6030fcead322c106f07640336115"><code>15af22f</code></a> refactor: add a noop handler for the error event</li> <li><a href="https://github.com/socketio/socket.io/commit/d3658944e562e538db094ef298d274821984dea2"><code>d365894</code></a> chore: bump socket.io-parser to version 4.2.3</li> <li><a href="https://github.com/socketio/socket.io/commit/12b0de4f524083c31b613ce33e4fd9f8d313f434"><code>12b0de4</code></a> chore: bump engine.io to version 6.4.2</li> <li><a href="https://github.com/socketio/socket.io/commit/3d44aae381af38349fdb808d510d9f47a0c2507e"><code>3d44aae</code></a> fix(exports): move <code>types</code> condition to the top (<a href="https://redirect.github.com/socketio/socket.io/issues/4698">#4698</a>)</li> <li><a href="https://github.com/socketio/socket.io/commit/cbf0362476a23a573233369f1119f7e305539336"><code>cbf0362</code></a> docs(examples): bump dependencies for the private messaging example</li> <li><a href="https://github.com/socketio/socket.io/commit/59280da20b5ab6509bafb87793cc0077d60d9c27"><code>59280da</code></a> docs(examples): update examples to docker compose v2</li> <li><a href="https://github.com/socketio/socket.io/commit/50a4d37cb82f2a14e058ae5a3038ee25796c2121"><code>50a4d37</code></a> docs(changelog): add version of transitive dependencies</li> <li><a href="https://github.com/socketio/socket.io/commit/6458b2bef171aa0d7dea198297608ea2ed4b1db9"><code>6458b2b</code></a> docs(example): basic WebSocket-only client</li> <li><a href="https://github.com/socketio/socket.io/commit/b56da8a99f4814d553064af175edcf747d5561d7"><code>b56da8a</code></a> docs(examples): upgrade to React 18</li> <li>See full diff in <a href="https://github.com/socketio/socket.io/compare/4.6.1...4.6.2">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=socket.io&package-manager=npm_and_yarn&previous-version=4.6.1&new-version=4.6.2)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/appsmithorg/appsmith/network/alerts). </details> <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9591866384> > Commit: dd65e51 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9591866384&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Sanity` <!-- end of auto-generated comment: Cypress test results --> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
## Description This PR does the code split of consolidated API to support adding the environment details consolidated API in EE, as mentioned here in the issue. - #33132 Fixes #33132 ## Automation /ok-to-test tags="@tag.Perf" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9595115979> > Commit: 7e9cbe0 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9595115979&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Perf` <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced a consolidated API response structure to streamline data from various endpoints, including user profiles, feature flags, and more. - Added comprehensive support for loading consolidated page information, enhancing the efficiency of page load operations. - **Refactor** - Refactored internal service interfaces and implementations to improve maintainability and extendability. - Centralized the `getConsolidatedInfoForPageLoad` method for better code organization and usability. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Abhijeet <[email protected]>
## Description - Add excludeFromTabOrder for WDS widgets - WDS Table refactoring Fixes #32369 ## Automation /ok-to-test tags="@tag.Anvil" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9596169254> > Commit: 25d5ef47520266d904c3c545940ad6009e7b2a8f > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9596169254&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Anvil` <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced the ability to exclude toolbar buttons from the tab order for improved accessibility and user experience. This can be controlled via the `excludeFromTabOrder` property. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
/ok-to-test tags="@tag.Anvil" <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced test cases for Anvil Button Widgets, including Canvas, Preview, and Deploy modes. - **Bug Fixes** - Updated CSS and HTML selectors for better element targeting and testing reliability. - **Style** - Improved styling logic for buttons in the InlineButtons component. - **Chores** - Added `data-testid` attributes for better test targeting. - Refactored code for string concatenations and URL constructions in DeployModeHelper. <!-- end of auto-generated comment: release notes by coderabbit.ai --><!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9597157402> > Commit: c551705 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9597157402&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Anvil` <!-- end of auto-generated comment: Cypress test results --> --------- Co-authored-by: Pawan Kumar <[email protected]>
Should fix the flood of buffer overflow errors we see from Supervisor. The one "change" this PR has, is that all the logs from the Docker container will now be coming from `stderr`, not `stdout`. I don't expect it to cause any problems, but it _is_ a change in behaviour nonetheless. Why do that? Because of the way Supervisor event listening works. This fix is based on the conversation at Supervisor/supervisor#1417. Essentially that `stdout` should be reserved as a communication channel between Supervisord and the event-listener, and for logging, we should use `stderr`. **/test sanity** <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9592028116> > Commit: 34a29ea > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9592028116&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Sanity` <!-- end of auto-generated comment: Cypress test results --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Refactor** - Improved logging by switching to `print` statements with explicit flushing for more reliable output handling. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
## Description Revert to passing hook as a prop for EE compatibility. Fixes #32982 ## Automation /ok-to-test tags="@tag.IDE" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9600106265> > Commit: 042f945 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9600106265&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.IDE` <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enhanced navigation menu generation in the editor with improved data management. - **Refactor** - Updated the navigation menu logic to use a new function, improving code maintainability and data handling. - **Bug Fixes** - Fixed inconsistencies in the navigation menu across different components in the editor. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Unused on EE as well. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Refactor** - Simplified internal logic by updating methods to use projections instead of fetching specific fields. - **Chores** - Removed deprecated methods related to fetching page slugs by application IDs to streamline the codebase. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
## Description Reverted missed out code in #34367 ## Automation /ok-to-test tags="@tag.IDE" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9608916182> > Commit: a252566 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9608916182&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.IDE` <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No
<!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Chores** - Updated workflow conditions to ensure PostgreSQL build is triggered when the pull request head reference is 'pg'. - Simplified logic to unconditionally start the PostgreSQL container in the build process. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
We're upgrading embedded Postgres from 13 to 14, and this PR includes a script to perform the upgrade of the data folder from v13 schema to v14 schema. This script temporarily installs Postgres 13, if not available, for the upgrade process, so will continue to work when and if we choose to remove `postgresql-13` from the base image. Tested this manually as well, running an Appsmith with Postgres 13, executing some workflows via webhook, getting some run data generated, then upgrading Postgres with the script in this PR, and ensuring that the workflow run history is still there and visible on the UI exactly the same. It is. No conflicts or additional changes needed on EE. [All server and Cypress tests pass on EE](appsmithorg/appsmith-ee#4493). ![shot-2024-06-20-02-13-26](https://github.com/appsmithorg/appsmith/assets/120119/9bb60e3a-6cc9-4df9-9064-caead78729a6) **/test sanity** <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9590240540> > Commit: 9c75da5 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9590240540&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Sanity` <!-- end of auto-generated comment: Cypress test results --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Added automation script for upgrading PostgreSQL to the latest version. - Introduced testing script for PostgreSQL upgrades in Docker environments. - **Improvements** - Upgraded PostgreSQL from version 13 to 14 in Docker setup, ensuring compatibility and performance enhancements. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
…4389) ## Description The request key used to store the mutex for prefetch request was including all header keys. The prefetch request created by the service worker only had one key (branchname) but the request initiated by the client had more headers. Because of this mismatch in keys the request was missing the cache. Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!IMPORTANT] > 🟣 🟣 🟣 Your tests are running. > Tests running at: <https://github.com/appsmithorg/appsmith/actions/runs/9612628976> > Commit: e9c4a98 > Workflow: `PR Automation test suite` > Tags: `` <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Improved request key generation by including specific headers, enhancing cache performance. - **Tests** - Added a test case to verify the new request key generation logic based on headers. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
## Description Fixed the alignment of icons inside tabs container. Fixes #34532 ## Automation /ok-to-test tags="@tag.Sanity, @tag.IDE" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10035753491> > Commit: e9ea2fc > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10035753491&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Sanity, @tag.IDE` > Spec: > <hr>Mon, 22 Jul 2024 06:52:30 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Style** - Improved visual alignment of icons within the tab by adjusting padding in the `StyledTab` component. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
## Description Fixed padding for add and list view of tab as per design. Fixes #34529 ## Automation /ok-to-test tags="@tag.IDE, @tag.Sanity" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10035415378> > Commit: 03296dd > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10035415378&attempt=2" target="_blank">Cypress dashboard</a>. > Tags: `@tag.IDE, @tag.Sanity` > Spec: > <hr>Mon, 22 Jul 2024 07:39:55 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **User Interface Enhancements** - Adjusted padding and layout properties across various components to improve visual alignment and spacing. - Simplified component structures by removing unnecessary padding properties. - **Bug Fixes** - Resolved potential issues related to visual inconsistencies caused by previous padding configurations. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
## Description Adding a prop to JSResponse View component to accept the default search text for the logs tab PR for appsmithorg/appsmith-ee#4695 ## Automation /ok-to-test tags="@tag.JS" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9961504301> > Commit: d6faf19 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9961504301&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.JS` > Spec: > <hr>Tue, 16 Jul 2024 18:08:24 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enhanced Debugger Logs: Users can now see a default name in the debugger logs if provided, improving clarity and traceability. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
## Description Fixes #34336 ~It was rare before, but with some lighter seeds borders could be perceivably more prominent than fg. I made sure this can't be the case.~ Borders are now lighter and less saturated than accents to emphasize the text label. | Before | After | |--------|--------| | ![before-light](https://github.com/appsmithorg/appsmith/assets/80973/627b3dae-287a-464d-89bb-0b3f0fbada79) | ![after-light](https://github.com/appsmithorg/appsmith/assets/80973/b4ffda8d-bc4b-4e84-a863-f22de3dce9b1) | | ![before-dark](https://github.com/appsmithorg/appsmith/assets/80973/f5897183-0f39-4b34-a6f6-3ef4f8c05fdb) | ![after-dark](https://github.com/appsmithorg/appsmith/assets/80973/6f07ffff-081b-4c0b-91a4-74edcf8d0995) | ## Automation /ok-to-test tags="@tag.Anvil" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9889245682> > Commit: b1769eb > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9889245682&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Anvil` > Spec: > <hr>Thu, 11 Jul 2024 10:09:49 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enhanced snapshot testing with a new `comparisonMethod` parameter for improved image comparison in `AnvilSnapshot`. - **Improvements** - Adjusted color calculations in Light Mode and Dark Mode themes for better contrast and visual consistency. - **Tests** - Updated color tests to align with new RGB values reflecting changes in lightness, chroma, and hue for both Light Mode and Dark Mode themes. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Valera Melnikov <[email protected]>
## Description Fixes #34584 | Before | After | |--------|--------| | ![before](https://github.com/user-attachments/assets/b0d58e3b-006e-49cc-af7f-5c600326caed) | ![after](https://github.com/user-attachments/assets/935590ea-2a3b-4912-a28c-16b47ba9d83c) | We had [a CSS rule](https://github.com/appsmithorg/appsmith/blob/f6d62e5cdc7c0c6900559107d77adbcad60b36a0/app/client/packages/design-system/widgets/src/styles/src/text-input.module.css#L27-L30) that was imitating CapSize behavior. It worked okay with regular input but had no effect on TextArea. Fixing it to work for TextArea did not seem possible no matter what CSS rules or additional markup I threw at it: <details><summary>Dev tools screenshots</summary> <p> <table> <tr> <td> <img width="1252" alt="Screenshot 2024-07-12 at 10 32 30" src="https://github.com/user-attachments/assets/c529f8b9-b129-4358-88e1-cee59a0797a6"> </td> <td> <img width="1270" alt="Screenshot 2024-07-12 at 10 32 40" src="https://github.com/user-attachments/assets/52cc122e-cc0b-4e18-84d5-006b5ed56ef1"> </td> </tr> </table> </p> </details> Changing the inner spacing and removing that rule achieves the desired results: elements are neatly aligned with similar/equal paddings. See the example with additional elements alongside TextInput and TextArea that verifies that vertical alignment is consistent: ![after-extras](https://github.com/user-attachments/assets/8fa7e867-22a8-4790-a0fc-daf76ccd5dbc) ## Automation /ok-to-test tags="@tag.Anvil" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9906310028> > Commit: 0c83d24 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9906310028&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Anvil` > Spec: > <hr>Fri, 12 Jul 2024 10:43:05 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [X] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Style** - Updated vertical padding for text input fields to improve spacing and visual clarity. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
## Description > [!TIP] > _Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team)._ > > _Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR._ Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.Anvil" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9942515767> > Commit: db1ef7c > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9942515767&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Anvil` > Spec: > <hr>Mon, 15 Jul 2024 16:12:38 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enhanced icon library with new thematic icons and improved accessibility features. - Introduced a default option in dropdowns for color selection in the property pane. - **Bug Fixes** - Corrected naming inconsistencies in icon entries. - **Improvements** - Streamlined color handling for icon and text components, enhancing visual coherence. - Update to the icon component's logic for improved maintainability and clarity. - **Documentation** - Added comments for better understanding of the handling of type errors in the icon component's story. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
## Description This change will remove applying spotless when compiling code and instead will apply spotless in the precommit hook. This will lead to faster build times and DX improvement as developer need not to manually run spotless anymore. Fixes #35056 ## Automation /test sanity ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10040567648> > Commit: 5872049 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10040567648&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Sanity` > Spec: > <hr>Mon, 22 Jul 2024 12:41:36 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Summary by CodeRabbit - **New Features** - Improved the formatting application process for server files, providing clearer feedback on success or failure. - **Bug Fixes** - Adjusted the build process to ensure a more streamlined execution of plugin goals. - **Chores** - Enhanced messaging and readability in scripts for better user experience. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
/ok-to-test tags="@tag.Anvil" <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced theme setting and snapshot verification for various widgets in different modes (Canvas, Preview, Deploy). - Added a new CSS rule to enhance the styling of input elements based on specific conditions. - **Refactor** - Renamed existing snapshot verification methods to more descriptive names across multiple widget snapshot files. - Added methods to handle theme settings and detailed snapshot matching. - **Tests** - Enhanced testing functionality for widgets with updated methods for snapshot verification across different themes. These updates ensure more detailed and theme-specific snapshot testing for various widget states, improving test coverage and accuracy, as well as enhancing the layout consistency of input elements. <!-- end of auto-generated comment: release notes by coderabbit.ai --> <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10046186626> > Commit: a6232ae > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10046186626&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Anvil` > Spec: > <hr>Mon, 22 Jul 2024 18:43:52 UTC <!-- end of auto-generated comment: Cypress test results --> --------- Co-authored-by: Pawan Kumar <[email protected]> Co-authored-by: Valera Melnikov <[email protected]>
## Description Fix text wrapping into paragraph and heading widgets ## Automation /ok-to-test tags="@tag.Anvil" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10047055173> > Commit: d0f7b27 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10047055173&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Anvil` > Spec: > <hr>Mon, 22 Jul 2024 19:49:10 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced a new `wordBreak` property to the text component for improved control over text wrapping and overflow. - Enhanced the `WDSParagraphWidget` to utilize the new `wordBreak` property, improving text layout and readability. - **Bug Fixes** - Corrected a typo in documentation for the `TextProps` interface to enhance clarity. - **Style** - Modified CSS styles affecting text overflow behavior, enabling better customization and responsive design. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
## Description > [!TIP] > _Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team)._ > > _Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR._ Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.Git" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!IMPORTANT] > 🟣 🟣 🟣 Your tests are running. > Tests running at: <https://github.com/appsmithorg/appsmith/actions/runs/10052956494> > Commit: c36c6a9 > Workflow: `PR Automation test suite` > Tags: `@tag.Git` > Spec: `` > <hr>Tue, 23 Jul 2024 04:56:36 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enhanced JSON deserialization to preserve float values accurately, improving data integrity during processing. - **Documentation** - Added comments to clarify the purpose of changes in the deserialization process. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
## Description Updated new tab ui with search, load more and updated titles. Fixes #34809, #34530 ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10036807357> > Commit: 2d37c01 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10036807357&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.All` > Spec: > <hr>Mon, 22 Jul 2024 08:46:24 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Summary by CodeRabbit - **New Features** - Added search functionality in the JS and Query Editor Panes to filter and display grouped items based on search terms. - Introduced a new component to render grouped lists with dynamic load more functionality. - **Enhancements** - Improved text and terminology for clearer user understanding in various modules. - Enhanced layout alignment by adjusting component heights to account for editor tabs. - **Refactor** - Improved type safety and refined logic in multiple functions for better performance and maintainability. - Replaced hardcoded values with constants for consistent and easier management. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
…sage (#35086) ## Description Adds placeholder functions to transform trigger eval error in EE PR for appsmithorg/appsmith-ee#4695 ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10040597202> > Commit: 784d698 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10040597202&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.All` > Spec: > <hr>Mon, 22 Jul 2024 13:11:23 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced a new function for processing evaluation errors, enhancing error management capabilities. - Improved error handling in the evaluation process for better debugging and clarity. - **Bug Fixes** - Enhanced type safety and clarity by incorporating new type definitions related to evaluation errors. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
## Description Issue: The GRAPHQL plugin logo is shown same as RestAPI plugin. Fix: Imported the right logo for graphql and used the right image in the img tag Fixes #34961 ## Automation /ok-to-test tags="@tag.Sanity @tag.IDE" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!CAUTION] > If you modify the content in this section, you are likely to disrupt the CI result for your PR. <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Updated the New API screen to display the GraphQL logo instead of the Plus logo. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
## Description Fixes canvas resizing issue and introduces performance improvements. Fixes #34741 ## Automation /ok-to-test tags="@tag.IDE" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9976888930> > Commit: 89ccd69 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9976888930&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.IDE` > Spec: > <hr>Wed, 17 Jul 2024 15:42:40 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced auto-resize functionality for canvas elements based on container width. - Added debouncing for resize events to improve performance. - **Refactor** - Reorganized imports and constants for better modularity and maintainability. - Updated component and hook references to use new `useCanvasWidthAutoResize`. - **Tests** - Added tests for canvas width resolution logic to ensure correct behavior across different layout types. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
) ## Description Fixes sniping for module instances. For binding to widgets, the module instance id and moduleInstance name was to be passed to the `BindDataButton` component. Fixes #31957 ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10056587287> > Commit: 74ec4dc > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10056587287&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.All` > Spec: > <hr>Tue, 23 Jul 2024 10:37:32 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [x] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced new `apiName` prop in the `ApiResponseView` component for enhanced flexibility in API response rendering. - Added `moduleInstanceId` to `BindDataButtonProps` for improved data binding context. - Enhanced `QueryResponseTab` components by adding `actionName` prop, improving functionality and display. - **Bug Fixes** - Updated logic in `QueryResponseTab` to allow for fallback to `actionName` when rendering, enhancing adaptability. - **Tests** - Added a comprehensive test suite for `bindDataToWidgetSaga` to ensure expected behavior and integration with Redux state management. - **Refactor** - Improved the logic in `bindDataToWidgetSaga` to utilize `actionName`, streamlining the data binding process. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
## Description Attached the attempt and changed the workflow name in order to trigger slack workflow > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!CAUTION] > If you modify the content in this section, you are likely to disrupt the CI result for your PR. <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Improved automation for analyzing Cypress test runs with refined conditional logic. - Enhanced data sent in analysis requests, including a new attempt number field for better traceability. - **Bug Fixes** - Ensured the automated analysis workflow only triggers under specific conditions, preventing unnecessary executions. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Signed-off-by: Laveena Enid <[email protected]>
## Description Please refer this document for more details - https://www.notion.so/appsmith/Transaction-Handling-in-PG-468cf8d4255749c3915699e59e91dc2f ## Automation /ok-to-test tags="@tag.Git, @tag.ImportExport, @tag.Templates" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10053864056> > Commit: 0b83e89 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10053864056&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Git, @tag.ImportExport, @tag.Templates` > Spec: > <hr>Tue, 23 Jul 2024 06:45:31 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enhanced import functionality to support themes and better handle applications. - **Bug Fixes** - Improved handling of application and theme imports in various scenarios, fixing related issues. - **Tests** - Updated test cases to validate the new and improved import functionality for themes and applications. These changes improve the robustness and flexibility of application and theme management during imports. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
## Description I noticed that some changes were not being detected, and I made the snapshot checks more strict. Now we will notice the absence of the icon. ![anvilButtonWidgetCanvas diff](https://github.com/user-attachments/assets/fc4e996d-daa1-419b-b71e-71675e29bc86) Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.Anvil" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10064554043> > Commit: 32260d6 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10064554043&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Anvil` > Spec: > <hr>Tue, 23 Jul 2024 19:11:18 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No
## Description This reverts commit cbe1f58. ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10072532868> > Commit: 9ab856d > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10072532868&attempt=2" target="_blank">Cypress dashboard</a>. > Tags: `@tag.All` > Spec: > <hr>Wed, 24 Jul 2024 09:06:01 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No
## Description > [!TIP] > _Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team)._ > > _Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR._ Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.Sanity" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10070546330> > Commit: e7ee6fa > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10070546330&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Sanity` > Spec: > <hr>Wed, 24 Jul 2024 04:58:18 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enhanced telemetry management with the integration of OpenTelemetry metrics for real-time performance monitoring. - New capabilities for exporting application metrics alongside existing tracing functionality. - **Bug Fixes** - Improved clarity and maintainability of resource attributes and variable naming conventions in telemetry management. - **Chores** - Updated dependency versions for OpenTelemetry packages, ensuring enhanced observability and performance tracking capabilities. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
## Description Remove the execution time calculation via stopwatch. This was used for profiling earlier but not required anymore and pollutes the logs. ## Automation /ok-to-test tags="@tag.Templates" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10088622540> > Commit: acfae67 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10088622540&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Templates` > Spec: > <hr>Thu, 25 Jul 2024 05:37:39 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Chores** - Removed stopwatch logging for performance monitoring during the import process to simplify code. The overall functionality of importing resources remains unchanged. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
) ## Description This PR added state reset for loading statuses. Fixes #35108 ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10090010865> > Commit: 654d8f6 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10090010865&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.All` > Spec: > <hr>Thu, 25 Jul 2024 08:28:22 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced a mechanism to reset the saving state of the editor across multiple Redux reducers, enhancing state management during user interactions. - Added explicit tracking for loading states within the editor reducer to improve UI feedback during saving operations. - **Bug Fixes** - Corrected handling of the `RESET_EDITOR_REQUEST` action to ensure appropriate state resets across various reducers, improving overall application responsiveness. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
## Description **Issue** In the table widget, the select column currently displays the value from the dropdown when a user makes a selection, rather than the label. This behaviour is inconsistent with the standalone select widget, which correctly renders the label upon selection. **Fix** This PR addresses the inconsistency by modifying the table widget's select column to display the label of the selected item, while maintaining the table cell value and ensuring alignment with the behaviour of the standalone select widget. **Tested Cases** Manual Test Cases for Table Select Widget Improvement 1. Default Value Display **Objective:** Ensure that a new table displays the correct default label key from the selectOptions in the cell. **Steps:** - Drop a new table widget. - Add sample data to the table. - Set a column (e.g., gender) to select type. - Verify that the table cell displays the value from the label key of the `selectOptions` by default. 2. Binding Check for Selected Row **Objective:** Ensure that the table binding for the selected row reflects the correct value key from the selectOptions. **Steps:** - Drop a new table widget. - Add sample data to the table. - Set a column (e.g., gender) to select type. - Select a row and verify that `Table1.selectedRow.gender` matches the value key from the `selectOptions`. 3. Updating Table Cell Content **Objective:** Verify that updating the table cell content via the dropdown updates the cell with the correct label key property. **Steps:** - Drop a new table widget. - Add sample data to the table. - Set a column (e.g., gender) to select type. - Change the content of the table cell using the dropdown. - Confirm that the cell content updates accordingly with the value key property. 4. Add New Row Functionality **Objective:** Ensure that adding a new row works as expected with the enhanced functionality. **Steps:** - Drop a new table widget. - Add sample data to the table. - Set a column (e.g., gender) to select type. - Add a new row to the table. - Verify that the new row uses the label key property from the `selectOptions` in the table display. 5. Deployed Mode Verification **Objective:** Verify that the display functionality works correctly in deployed mode. **Steps:** - Drop a new table widget. - Add sample data to the table. - Set a column (e.g., gender) to select type. - Change the displayAs property to both value and label. - Deploy the table. - Verify that the table displays correctly in both value and label modes in the deployed environment. Fixes #26188 ## Automation /ok-to-test tags="@tag.Table, @tag.Binding, @tag.Sanity" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10080592979> > Commit: 78b268d > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10080592979&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Table, @tag.Binding, @tag.Sanity` > Spec: > <hr>Wed, 24 Jul 2024 17:17:06 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Improved display of selected options in table widgets by showing the corresponding label instead of the raw value. - Introduced a feature flag to toggle the table cell label value functionality. - **Bug Fixes** - Enhanced test cases to ensure accurate validation of select options behavior within the table widget. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
## Description When create datasource is initiated from the API editor by clicking "Save as datasource", it fixes the redirection back to the API editor when `Save` is clicked for modules in package editor. This PR also refactors the usage of typing of `actionRouteInfo` and introduces `parentEntityId` instead of using `pageId`, `moduleId`, `workflowId` separately. This fix also verifies the sanity of 1. API in apps 2. API in workflows Fixes #31506 ## Automation /ok-to-test tags="@tag.Datasource,@tag.Sanity" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10093685845> > Commit: 785cbe3 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10093685845&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Datasource,@tag.Sanity` > Spec: > <hr>Thu, 25 Jul 2024 12:39:50 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced a new function to retrieve the current module ID, enhancing state management. - Added support for handling `parentEntityId` in various data source sagas. - **Bug Fixes** - Improved type safety for action handling in sagas. - **Tests** - Added a new test suite for the `handleDatasourceCreatedSaga` to validate its behavior upon datasource creation. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
…rors thrown by Appsmith (#35160) ## Description > Extend OAuth2AuthenticationException so that we can differentiate between AppsmithException and exceptions thrown by Spring Library. > There is not going to be any change to the Authentication flows here, as the we are just inheriting the OAuth2AuthenticationException. Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10092949232> > Commit: bc2f204 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10092949232&attempt=2" target="_blank">Cypress dashboard</a>. > Tags: `@tag.All` > Spec: > <hr>Thu, 25 Jul 2024 13:13:00 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced a new custom exception for improved handling of OAuth 2.0 authentication errors, enhancing the clarity and robustness of the authentication process. - **Bug Fixes** - Enhanced error categorization in the authentication process by refining the error handling logic, allowing for better management of exceptions related to OAuth 2.0. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Nilesh Sarupriya <[email protected]>
## Description issue of Postgres not coming up with error` Previous Postgres was not shutdown cleanly. Please start and stop Postgres 14 properly with 'supervisorctl' only. ` https://www.notion.so/appsmith/Closed-Beta-Customer-issues-45a274a9eb8e4762a72cbff74cd3bad5?pvs=4#ecca04d205414f25a289884cebdc0f9b Fixes https://app.zenhub.com/workspaces/workflows-pod-652fff131a95920b9bf2bc7e/issues/zh/226_ ## Automation /ok-to-test tags="@tag.Sanity" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10107093349> > Commit: 357bf5d > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10107093349&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Sanity` > Spec: > <hr>Fri, 26 Jul 2024 07:15:19 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Summary by CodeRabbit - **New Features** - Enhanced PostgreSQL upgrade process with improved error handling and robust management of old server instances. - **Bug Fixes** - Reinstituted logic for checking and managing the `postmaster.pid` file, ensuring proper startup and shutdown of old PostgreSQL servers. - **Refactor** - Improved formatting and readability of shell scripts without altering their functionality. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
## Description Capturing telemetry of widget renders and only enabling the profiled build for community users. This should cause a minor performance overhead and in case performance degrades too much we can disable the widget profiled telemetry by disabling the new relic flag(set this to false `APPSMITH_NEW_RELIC_ACCOUNT_ENABLE`). Fixes #35184 > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.Sanity" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10111247316> > Commit: 38310d7 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10111247316&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Sanity` > Spec: > <hr>Fri, 26 Jul 2024 12:55:43 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Summary by CodeRabbit - **New Features** - Introduced `WidgetProfiler` component to track rendering performance metrics. - Added a new function for enhanced telemetry span management. - **Improvements** - Updated build script to allow for profiled builds based on environment variables, improving performance analysis. - Implemented GZIP compression for OTLP trace data transmission, optimizing bandwidth usage. - **Refactor** - Removed `Sentry.withProfiler` for widget profiling, simplifying performance monitoring. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )