Skip to content

Commit

Permalink
fix: resetWidget doesn't reset child widgets inside a list (appsmitho…
Browse files Browse the repository at this point in the history
…rg#30121)

## Description
> Fixes issue with resetWidget platform function not honouring
`resetChildren` argument. Also, takes care of resetting meta widgets
inside a list.
These bug was introduced in appsmithorg#29151, where we moved the resetWidget logic
to the worker thread, to support restoration of default values in meta
fields (post setter methods invocation).
>
>
#### PR fixes following issue(s)
Fixes appsmithorg#30116 

#### Type of change
- Bug fix (non-breaking change which fixes an issue)
>
## Testing
>
#### How Has This Been Tested?
- [x] Manual
>
#### Test Plan
> Add Testsmith test cases links that relate to this PR
>
>
#### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
>
>
>
## Checklist:
#### Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [x] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

## Summary by CodeRabbit

- **Refactor**
- Streamlined evaluation logic for better performance and
maintainability.
- **New Features**
  - Enhanced widget reset functionality with improved cache handling.
- Upgraded library installation process for JavaScript libraries within
the app, ensuring more reliable and consistent performance.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
  • Loading branch information
arunvjn authored Jan 9, 2024
1 parent 4c76406 commit a9b0e58
Show file tree
Hide file tree
Showing 6 changed files with 756 additions and 15 deletions.
Original file line number Diff line number Diff line change
@@ -1,12 +1,13 @@
import { data } from "cypress/types/jquery";
import {
agHelper,
apiPage,
jsEditor,
debuggerHelper,
dataManager,
locators,
draggableWidgets,
} from "../../../../support/Objects/ObjectsCore";
import EditorNavigation from "../../../../support/Pages/EditorNavigation";

describe(
"Tests functionality of platform function",
Expand Down Expand Up @@ -177,5 +178,52 @@ describe(
agHelper.ValidateToastMessage("Hello World", 0);
agHelper.ValidateToastMessage("Hello World", 1);
});

it("3. Bug 30121 Reset widget should reset children as well when resetChildren argument is set to true", () => {
EditorNavigation.ShowCanvas();
agHelper.AddDsl("resetWidgetDSL");
agHelper.ClearNType(
locators._widgetInDeployed(draggableWidgets.INPUT_V2) + " input",
"Hello! How are you?",
0,
);

agHelper.ClickButton("ResetContainer");

agHelper.AssertText(
locators._widgetInDeployed(draggableWidgets.INPUT_V2) + " input",
"text",
"",
0,
);

agHelper.ClearNType(
locators._widgetInDeployed(draggableWidgets.INPUT_V2) + " input",
"Hello! How are you?",
1,
);

agHelper.ClearNType(
locators._widgetInDeployed(draggableWidgets.INPUT_V2) + " input",
"Hello! How are you?",
2,
);

agHelper.ClickButton("ResetList");

agHelper.AssertText(
locators._widgetInDeployed(draggableWidgets.INPUT_V2) + " input",
"text",
"",
1,
);

agHelper.AssertText(
locators._widgetInDeployed(draggableWidgets.INPUT_V2) + " input",
"text",
"",
2,
);
});
},
);
Loading

0 comments on commit a9b0e58

Please sign in to comment.