Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

records: Handle pagination in data source. #979

Merged
merged 1 commit into from
Apr 20, 2023
Merged

Conversation

andrewsomething
Copy link
Member

@andrewsomething andrewsomething commented Apr 20, 2023

The domain record data source does not handle pagination properly causing any record found on the second page of results to be missed.

Fixes: #978

Copy link

@mikeberezowski mikeberezowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah LGTM 👍

Copy link
Member

@danaelhe danaelhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@andrewsomething andrewsomething merged commit 21de5e5 into main Apr 20, 2023
@andrewsomething andrewsomething deleted the asb/issues/978 branch April 20, 2023 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

digitalocean_record data source issue
3 participants