kubernetes: Require importing additional node pools manually. #976
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #892 by only importing the default node pool when importing a cluster. Additional pools should now be imported separately as
digitalocean_kubernetes_node_pool
resources.The old approach of importing multiple resources in one go was fragile, and the upstream Terraform developer documentation has begun to actively discourage it:
https://developer.hashicorp.com/terraform/plugin/sdkv2/resources/import#multiple-resource-import
Other providers like AWS' have removed all usage of "complex imports," hashicorp/terraform-provider-aws#13408.
I think this is likely a bug in upstream Terraform. Though this "feature" is not widely used, and they are clearly trying to move away from it. So I believe this is the best approach moving forward.
Fixes: #892