Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add registry_integration to Schema #963

Conversation

mohsenSy
Copy link
Contributor

registry_integration can be true to integrate the kubernetes cluster with container registry, or false to disable this integration If there is no container registry in the team's or user's account then terraform will taint the resource and re-create the clsuter on next apply, it is recommended to make your doks resource depends on the Digital Ocean container registry resource to avoid re-creating the kubernetes cluster

registry_integration can be true to integrate the kubernetes cluster
with container registry, or false to disable this integration
If there is no container registry in the team's or user's account
then terraform will taint the resource and re-create the clsuter
on next apply, it is recommended to make your doks resource
depends on the Digital Ocean container registry resource
to avoid re-creating the kubernetes cluster
@mohsenSy mohsenSy force-pushed the add-container-registry-kubernetes-integration branch from 2f1b3ef to 6fc89fe Compare March 22, 2023 21:33
Copy link
Member

@andrewsomething andrewsomething left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this great contribution! Sorry that we've taken so long to review it.

I had one small suggestion in-line. It would also be great to document the new option here:

https://github.com/digitalocean/terraform-provider-digitalocean/blob/main/docs/resources/kubernetes_cluster.md#argument-reference

It would also be good to add an acceptance test. Let us know if you are interested in doing that. If not, we can take it from here.

digitalocean/kubernetes/resource_kubernetes_cluster.go Outdated Show resolved Hide resolved
@mohsenSy
Copy link
Contributor Author

@andrewsomething could you please have a second look? I added some tests, I hope they are correct. I cannot afford to test them locally

Copy link
Member

@andrewsomething andrewsomething left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick follow up! I've pushed a commit that fixes up a few things with the tests and consolidates them a bit. Creating multiple clusters adds some over head and the full suite already takes quite awhile to run.

We'll be looking to cut a release soon that includes this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants