Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sweeper for projects and add retry for project deletion. #943

Merged
merged 4 commits into from
Feb 13, 2023

Conversation

andrewsomething
Copy link
Member

This adds a sweeper for projects. Additionally it adds a retry for project deletion. Projects must be empty to be deleted. We handle reassigning resources to the default project, but this is an async process. Retrying deletion resolves some flaky tests.

$ make testacc PKG_NAME=digitalocean/project TESTARGS="-count=1"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test -v ./digitalocean/project/... -count=1 -timeout 120m -parallel=2
=== RUN   TestAccDataSourceDigitalOceanProject_DefaultProject
=== PAUSE TestAccDataSourceDigitalOceanProject_DefaultProject
=== RUN   TestAccDataSourceDigitalOceanProject_NonDefaultProject
=== PAUSE TestAccDataSourceDigitalOceanProject_NonDefaultProject
=== RUN   TestAccDataSourceDigitalOceanProjects_Basic
--- PASS: TestAccDataSourceDigitalOceanProjects_Basic (12.35s)
=== RUN   TestAccDigitalOceanProject_importBasic
=== PAUSE TestAccDigitalOceanProject_importBasic
=== RUN   TestAccDigitalOceanProjectResources_Basic
=== PAUSE TestAccDigitalOceanProjectResources_Basic
=== RUN   TestAccDigitalOceanProject_CreateWithDefaults
=== PAUSE TestAccDigitalOceanProject_CreateWithDefaults
=== RUN   TestAccDigitalOceanProject_CreateWithIsDefault
=== PAUSE TestAccDigitalOceanProject_CreateWithIsDefault
=== RUN   TestAccDigitalOceanProject_CreateWithInitialValues
=== PAUSE TestAccDigitalOceanProject_CreateWithInitialValues
=== RUN   TestAccDigitalOceanProject_UpdateWithInitialValues
=== PAUSE TestAccDigitalOceanProject_UpdateWithInitialValues
=== RUN   TestAccDigitalOceanProject_CreateWithDropletResource
=== PAUSE TestAccDigitalOceanProject_CreateWithDropletResource
=== RUN   TestAccDigitalOceanProject_UpdateWithDropletResource
=== PAUSE TestAccDigitalOceanProject_UpdateWithDropletResource
=== RUN   TestAccDigitalOceanProject_UpdateFromDropletToSpacesResource
=== PAUSE TestAccDigitalOceanProject_UpdateFromDropletToSpacesResource
=== RUN   TestAccDigitalOceanProject_WithManyResources
=== PAUSE TestAccDigitalOceanProject_WithManyResources
=== CONT  TestAccDataSourceDigitalOceanProject_DefaultProject
=== CONT  TestAccDigitalOceanProject_CreateWithInitialValues
--- PASS: TestAccDigitalOceanProject_CreateWithInitialValues (2.86s)
=== CONT  TestAccDigitalOceanProject_UpdateWithDropletResource
--- PASS: TestAccDataSourceDigitalOceanProject_DefaultProject (5.53s)
=== CONT  TestAccDigitalOceanProject_WithManyResources
--- PASS: TestAccDigitalOceanProject_WithManyResources (7.49s)
=== CONT  TestAccDigitalOceanProject_UpdateFromDropletToSpacesResource
--- PASS: TestAccDigitalOceanProject_UpdateWithDropletResource (72.90s)
=== CONT  TestAccDigitalOceanProjectResources_Basic
--- PASS: TestAccDigitalOceanProject_UpdateFromDropletToSpacesResource (85.99s)
=== CONT  TestAccDigitalOceanProject_CreateWithIsDefault
    resource_project_test.go:81: Restoring original default project: Terraform Acceptance Testing (5f6d8250-63c9-4310-90ea-f301a8174dcd)
--- PASS: TestAccDigitalOceanProject_CreateWithIsDefault (4.54s)
=== CONT  TestAccDigitalOceanProject_CreateWithDefaults
--- PASS: TestAccDigitalOceanProject_CreateWithDefaults (2.45s)
=== CONT  TestAccDigitalOceanProject_CreateWithDropletResource
--- PASS: TestAccDigitalOceanProjectResources_Basic (83.61s)
=== CONT  TestAccDigitalOceanProject_UpdateWithInitialValues
--- PASS: TestAccDigitalOceanProject_UpdateWithInitialValues (4.37s)
=== CONT  TestAccDigitalOceanProject_importBasic
--- PASS: TestAccDigitalOceanProject_importBasic (2.96s)
=== CONT  TestAccDataSourceDigitalOceanProject_NonDefaultProject
--- PASS: TestAccDataSourceDigitalOceanProject_NonDefaultProject (5.75s)
--- PASS: TestAccDigitalOceanProject_CreateWithDropletResource (79.13s)
PASS
ok      github.com/digitalocean/terraform-provider-digitalocean/digitalocean/project    197.501s

@andrewsomething andrewsomething requested a review from a team February 10, 2023 18:56
@andrewsomething andrewsomething temporarily deployed to Acceptance Tests February 10, 2023 18:59 — with GitHub Actions Inactive
@andrewsomething andrewsomething temporarily deployed to Acceptance Tests February 10, 2023 19:02 — with GitHub Actions Inactive
Copy link
Member

@danaelhe danaelhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrewsomething andrewsomething merged commit 489f9ac into main Feb 13, 2023
@andrewsomething andrewsomething deleted the asb/sweeper-projects branch February 13, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants