Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sweeper for SSH keys. #940

Merged
merged 4 commits into from
Feb 10, 2023
Merged

Add sweeper for SSH keys. #940

merged 4 commits into from
Feb 10, 2023

Conversation

andrewsomething
Copy link
Member

This adds a sweeper for SSH keys. It also removes a custom helper for generating keys for use in tests. The SDK already provides a helper for this that we use elsewhere. There is no need to duplicate that functionality.

$ make testacc PKG_NAME=digitalocean/sshkey 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test -v ./digitalocean/sshkey/...  -timeout 120m -parallel=5
=== RUN   TestAccDataSourceDigitalOceanSSHKey_Basic
=== PAUSE TestAccDataSourceDigitalOceanSSHKey_Basic
=== RUN   TestAccDataSourceDigitalOceanSSHKeys_Basic
=== PAUSE TestAccDataSourceDigitalOceanSSHKeys_Basic
=== RUN   TestAccDigitalOceanSSHKey_importBasic
=== PAUSE TestAccDigitalOceanSSHKey_importBasic
=== RUN   TestAccDigitalOceanSSHKey_Basic
=== PAUSE TestAccDigitalOceanSSHKey_Basic
=== CONT  TestAccDataSourceDigitalOceanSSHKey_Basic
=== CONT  TestAccDigitalOceanSSHKey_importBasic
=== CONT  TestAccDigitalOceanSSHKey_Basic
=== CONT  TestAccDataSourceDigitalOceanSSHKeys_Basic
--- PASS: TestAccDigitalOceanSSHKey_Basic (1.85s)
--- PASS: TestAccDigitalOceanSSHKey_importBasic (2.15s)
--- PASS: TestAccDataSourceDigitalOceanSSHKey_Basic (3.36s)
--- PASS: TestAccDataSourceDigitalOceanSSHKeys_Basic (5.21s)
PASS
ok      github.com/digitalocean/terraform-provider-digitalocean/digitalocean/sshkey     5.272s

@andrewsomething andrewsomething requested a review from a team February 9, 2023 23:06
@andrewsomething andrewsomething temporarily deployed to Acceptance Tests February 9, 2023 23:09 — with GitHub Actions Inactive
Copy link
Member

@danaelhe danaelhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍

@andrewsomething andrewsomething temporarily deployed to Acceptance Tests February 10, 2023 15:27 — with GitHub Actions Inactive
@andrewsomething andrewsomething merged commit 9a2d503 into main Feb 10, 2023
@andrewsomething andrewsomething deleted the asb/sweeper-ssh-keys branch February 10, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants