Package reorganization #927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewsomething
requested review from
bentranter,
scotchneat,
ChiefMateStarbuck and
danaelhe
andrewsomething
temporarily deployed
to
Acceptance Tests
GitHub Actions
Inactive
danaelhe
approved these changes
Feb 7, 2023
andrewsomething
added a commit
to andrewsomething/terraform-provider-digitalocean
that referenced
this pull request
Feb 7, 2023
* Initial reorganization. * Update Makefile for running accepance tests under new organization. * Update sweepers for new organization. * Remove unused functions from util package. * godo.PtrTo replaces the boolPtr and intPtr helpers. * Clean up util package. * Reorg helpers in acceptance package.
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request reorganizes the structure of this project to use multiple packages. As the provider has grown, it has become a bit unwieldy to work with as the majority of files were all in the same directory. By breaking this up into subpackages, it should be easier to quickly find the files you need. It should also simplify acceptance testing by being able to run the tests for a subpackage with out needing to craft regexps. For example, to only run the acceptance tests for the account package use:
When
PKG_NAMEis excluded, all acceptance tests are run.One place where this does add a bit of complexity is with the test sweepers. In order to collect sweepers across the packages, we need to use "blank" imports which can be easy to forget. See:
digitalocean/sweep/sweep_test.goIn a future iteration, we could potentially generate that. The AWS provider has some prior art that could provide some inspiration.While this is a huge PR, most of the changes are file renames and moving code to break import cycles.