Revert "Support HTTP idle timeout & Project ID" #904

andrewsomething · 2022-11-22T15:36:05Z

Reverts #897

This PR introduced a number of test failures. For example, this is not the ID of a real project so all tests using this config now fail:

terraform-provider-digitalocean/digitalocean/resource_digitalocean_loadbalancer_test.go

Line 744 in dc5ff85

project_id = "my-project-uuid"

$ make testacc TESTARGS='-run=TestAccDigitalOceanLoadbalancer'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run=TestAccDigitalOceanLoadbalancer -timeout 120m
?       github.com/digitalocean/terraform-provider-digitalocean [no test files]
=== RUN   TestAccDigitalOceanLoadbalancer_Basic
=== PAUSE TestAccDigitalOceanLoadbalancer_Basic
=== RUN   TestAccDigitalOceanLoadbalancer_Updated
=== PAUSE TestAccDigitalOceanLoadbalancer_Updated
=== RUN   TestAccDigitalOceanLoadbalancer_dropletTag
=== PAUSE TestAccDigitalOceanLoadbalancer_dropletTag
=== RUN   TestAccDigitalOceanLoadbalancer_minimal
=== PAUSE TestAccDigitalOceanLoadbalancer_minimal
=== RUN   TestAccDigitalOceanLoadbalancer_minimalUDP
=== PAUSE TestAccDigitalOceanLoadbalancer_minimalUDP
=== RUN   TestAccDigitalOceanLoadbalancer_stickySessions
=== PAUSE TestAccDigitalOceanLoadbalancer_stickySessions
=== RUN   TestAccDigitalOceanLoadbalancer_sslTermination
=== PAUSE TestAccDigitalOceanLoadbalancer_sslTermination
=== RUN   TestAccDigitalOceanLoadbalancer_sslCertByName
=== PAUSE TestAccDigitalOceanLoadbalancer_sslCertByName
=== RUN   TestAccDigitalOceanLoadbalancer_resizeExpectedFailure
=== PAUSE TestAccDigitalOceanLoadbalancer_resizeExpectedFailure
=== RUN   TestAccDigitalOceanLoadbalancer_multipleRules
=== PAUSE TestAccDigitalOceanLoadbalancer_multipleRules
=== RUN   TestAccDigitalOceanLoadbalancer_WithVPC
=== PAUSE TestAccDigitalOceanLoadbalancer_WithVPC
=== CONT  TestAccDigitalOceanLoadbalancer_Basic
=== CONT  TestAccDigitalOceanLoadbalancer_minimal
=== CONT  TestAccDigitalOceanLoadbalancer_sslTermination
=== CONT  TestAccDigitalOceanLoadbalancer_minimalUDP
=== CONT  TestAccDigitalOceanLoadbalancer_multipleRules
=== CONT  TestAccDigitalOceanLoadbalancer_WithVPC
=== CONT  TestAccDigitalOceanLoadbalancer_resizeExpectedFailure
=== CONT  TestAccDigitalOceanLoadbalancer_stickySessions
=== CONT  TestAccDigitalOceanLoadbalancer_sslTermination
    resource_digitalocean_loadbalancer_test.go:425: Step 1/1 error: Error running apply: exit status 1
        
        Error: Error creating Certificate: POST https://api.digitalocean.com/v2/certificates: 422 (request "7b8ea8dd-0b34-44dc-b25c-0a2edbbc6635") name is not unique
        
          with digitalocean_certificate.foobar,
          on terraform_plugin_test.tf line 2, in resource "digitalocean_certificate" "foobar":
           2: resource "digitalocean_certificate" "foobar" {
        
--- FAIL: TestAccDigitalOceanLoadbalancer_sslTermination (2.40s)
=== CONT  TestAccDigitalOceanLoadbalancer_dropletTag
=== CONT  TestAccDigitalOceanLoadbalancer_Basic
    resource_digitalocean_loadbalancer_test.go:58: Step 1/1 error: Error running apply: exit status 1
        
        Error: Error creating Load Balancer: POST https://api.digitalocean.com/v2/load_balancers: 400 (request "1eeb8215-13d7-4e45-b8c3-572f7c5438de") invalid project_id provided in the request payload
        
          with digitalocean_loadbalancer.foobar,
          on terraform_plugin_test.tf line 9, in resource "digitalocean_loadbalancer" "foobar":
           9: resource "digitalocean_loadbalancer" "foobar" {
        
--- FAIL: TestAccDigitalOceanLoadbalancer_Basic (62.84s)
=== CONT  TestAccDigitalOceanLoadbalancer_Updated
    resource_digitalocean_loadbalancer_test.go:117: Step 1/2 error: Error running apply: exit status 1
        
        Error: Error creating Load Balancer: POST https://api.digitalocean.com/v2/load_balancers: 400 (request "404c76a6-2040-42a0-9fa6-108fcef16c2e") invalid project_id provided in the request payload
        
          with digitalocean_loadbalancer.foobar,
          on terraform_plugin_test.tf line 9, in resource "digitalocean_loadbalancer" "foobar":
           9: resource "digitalocean_loadbalancer" "foobar" {
        
--- FAIL: TestAccDigitalOceanLoadbalancer_Updated (51.77s)
=== CONT  TestAccDigitalOceanLoadbalancer_sslCertByName
=== CONT  TestAccDigitalOceanLoadbalancer_multipleRules
    resource_digitalocean_loadbalancer_test.go:564: Step 1/2 error: After applying this test step, the plan was not empty.
        stdout:
        
        
        Terraform used the selected providers to generate the following execution
        plan. Resource actions are indicated with the following symbols:
          ~ update in-place
        
        Terraform will perform the following actions:
        
          # digitalocean_loadbalancer.foobar will be updated in-place
          ~ resource "digitalocean_loadbalancer" "foobar" {
              - http_idle_timeout_seconds        = 60 -> null
                id                               = "07b342e2-9bb5-425d-814d-ca8ac8c20480"
                name                             = "tf-acc-test-s4k9z7y21o"
                # (13 unchanged attributes hidden)
        
                # (4 unchanged blocks hidden)
            }
        
        Plan: 0 to add, 1 to change, 0 to destroy.
--- FAIL: TestAccDigitalOceanLoadbalancer_multipleRules (115.41s)
=== CONT  TestAccDigitalOceanLoadbalancer_stickySessions
    resource_digitalocean_loadbalancer_test.go:370: Step 1/1 error: After applying this test step, the plan was not empty.
        stdout:
        
        
        Terraform used the selected providers to generate the following execution
        plan. Resource actions are indicated with the following symbols:
          ~ update in-place
        
        Terraform will perform the following actions:
        
          # digitalocean_loadbalancer.foobar will be updated in-place
          ~ resource "digitalocean_loadbalancer" "foobar" {
              - http_idle_timeout_seconds        = 60 -> null
                id                               = "f6dddc62-2ea6-4abe-9c5b-6db3b959e2ac"
                name                             = "loadbalancer-220716403397759782"
                # (13 unchanged attributes hidden)
        
                # (3 unchanged blocks hidden)
            }
        
        Plan: 0 to add, 1 to change, 0 to destroy.
=== CONT  TestAccDigitalOceanLoadbalancer_minimalUDP
    resource_digitalocean_loadbalancer_test.go:316: Step 1/1 error: After applying this test step, the plan was not empty.
        stdout:
        
        
        Terraform used the selected providers to generate the following execution
        plan. Resource actions are indicated with the following symbols:
          ~ update in-place
        
        Terraform will perform the following actions:
        
          # digitalocean_loadbalancer.foobar will be updated in-place
          ~ resource "digitalocean_loadbalancer" "foobar" {
              - http_idle_timeout_seconds        = 60 -> null
                id                               = "1c3038b9-acf5-4d92-9340-6f6e50257f91"
                name                             = "loadbalancer-1884805253242388054"
                # (13 unchanged attributes hidden)
        
                # (3 unchanged blocks hidden)
            }
        
        Plan: 0 to add, 1 to change, 0 to destroy.
=== CONT  TestAccDigitalOceanLoadbalancer_minimal
    resource_digitalocean_loadbalancer_test.go:262: Step 1/1 error: After applying this test step, the plan was not empty.
        stdout:
        
        
        Terraform used the selected providers to generate the following execution
        plan. Resource actions are indicated with the following symbols:
          ~ update in-place
        
        Terraform will perform the following actions:
        
          # digitalocean_loadbalancer.foobar will be updated in-place
          ~ resource "digitalocean_loadbalancer" "foobar" {
              - http_idle_timeout_seconds        = 60 -> null
                id                               = "9be6ff90-98cc-44b9-b97a-3b483f586fb2"
                name                             = "loadbalancer-9180328754269989612"
                # (13 unchanged attributes hidden)
        
                # (3 unchanged blocks hidden)
            }
        
        Plan: 0 to add, 1 to change, 0 to destroy.
=== CONT  TestAccDigitalOceanLoadbalancer_dropletTag
    resource_digitalocean_loadbalancer_test.go:216: Step 1/1 error: After applying this test step, the plan was not empty.
        stdout:
        
        
        Terraform used the selected providers to generate the following execution
        plan. Resource actions are indicated with the following symbols:
          ~ update in-place
        
        Terraform will perform the following actions:
        
          # digitalocean_loadbalancer.foobar will be updated in-place
          ~ resource "digitalocean_loadbalancer" "foobar" {
              - http_idle_timeout_seconds        = 60 -> null
                id                               = "b10a6c0e-add4-4419-8007-3b8fa56c6dea"
                name                             = "loadbalancer-1012393044855707055"
                # (13 unchanged attributes hidden)
        
                # (3 unchanged blocks hidden)
            }
        
        Plan: 0 to add, 1 to change, 0 to destroy.
=== CONT  TestAccDigitalOceanLoadbalancer_WithVPC
    resource_digitalocean_loadbalancer_test.go:645: Step 1/1 error: After applying this test step, the plan was not empty.
        stdout:
        
        
        Terraform used the selected providers to generate the following execution
        plan. Resource actions are indicated with the following symbols:
          ~ update in-place
        
        Terraform will perform the following actions:
        
          # digitalocean_loadbalancer.foobar will be updated in-place
          ~ resource "digitalocean_loadbalancer" "foobar" {
              - http_idle_timeout_seconds        = 60 -> null
                id                               = "296d5a42-0146-433a-9aa1-f552b7f72df8"
                name                             = "tf-acc-test-2k3o1zik7o"
                # (13 unchanged attributes hidden)
        
                # (3 unchanged blocks hidden)
            }
        
        Plan: 0 to add, 1 to change, 0 to destroy.
--- FAIL: TestAccDigitalOceanLoadbalancer_stickySessions (163.30s)
--- FAIL: TestAccDigitalOceanLoadbalancer_minimalUDP (174.76s)
--- FAIL: TestAccDigitalOceanLoadbalancer_minimal (175.52s)
--- FAIL: TestAccDigitalOceanLoadbalancer_dropletTag (175.16s)
--- FAIL: TestAccDigitalOceanLoadbalancer_WithVPC (185.29s)
=== CONT  TestAccDigitalOceanLoadbalancer_sslCertByName
    resource_digitalocean_loadbalancer_test.go:470: Step 1/1 error: After applying this test step, the plan was not empty.
        stdout:
        
        
        Terraform used the selected providers to generate the following execution
        plan. Resource actions are indicated with the following symbols:
          ~ update in-place
        
        Terraform will perform the following actions:
        
          # digitalocean_loadbalancer.foobar will be updated in-place
          ~ resource "digitalocean_loadbalancer" "foobar" {
              - http_idle_timeout_seconds        = 60 -> null
                id                               = "fcdc6e94-337d-4868-af69-2f5c83ffe760"
                name                             = "loadbalancer-354221888777778271"
                # (13 unchanged attributes hidden)
        
                # (3 unchanged blocks hidden)
            }
        
        Plan: 0 to add, 1 to change, 0 to destroy.
--- FAIL: TestAccDigitalOceanLoadbalancer_sslCertByName (112.65s)
=== CONT  TestAccDigitalOceanLoadbalancer_resizeExpectedFailure
    resource_digitalocean_loadbalancer_test.go:537: Step 1/2 error: After applying this test step, the plan was not empty.
        stdout:
        
        
        Terraform used the selected providers to generate the following execution
        plan. Resource actions are indicated with the following symbols:
          ~ update in-place
        
        Terraform will perform the following actions:
        
          # digitalocean_loadbalancer.foobar will be updated in-place
          ~ resource "digitalocean_loadbalancer" "foobar" {
              - http_idle_timeout_seconds        = 60 -> null
                id                               = "3a504638-5045-4ae3-b676-64b478abfdea"
                name                             = "loadbalancer-8446999854889222114"
                # (12 unchanged attributes hidden)
        
                # (3 unchanged blocks hidden)
            }
        
        Plan: 0 to add, 1 to change, 0 to destroy.
--- FAIL: TestAccDigitalOceanLoadbalancer_resizeExpectedFailure (267.81s)
FAIL
FAIL    github.com/digitalocean/terraform-provider-digitalocean/digitalocean    268.452s
testing: warning: no tests to run
PASS
ok      github.com/digitalocean/terraform-provider-digitalocean/internal/datalist       0.003s [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/digitalocean/terraform-provider-digitalocean/internal/mutexkv        0.001s [no tests to run]
FAIL
make: *** [GNUmakefile:16: testacc] Error 1

This reverts commit dc5ff85.

bentranter

🤦‍♂️ Didn't realize that blast radius of the project ID was so significant. Revert LGTM!

Revert "Support HTTP idle timeout & Project ID (#897)"

b360ad1

This reverts commit dc5ff85.

andrewsomething requested a review from a team November 22, 2022 15:36

andrewsomething temporarily deployed to Acceptance Tests November 22, 2022 15:37 Inactive

bentranter reviewed Nov 22, 2022

View reviewed changes

bentranter approved these changes Nov 22, 2022

View reviewed changes

andrewsomething merged commit c3eed41 into main Nov 22, 2022

andrewsomething deleted the revert-897-LBAAS-2428-support-http-idle-timeout branch November 22, 2022 16:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Revert "Support HTTP idle timeout & Project ID" #904

Revert "Support HTTP idle timeout & Project ID" #904

andrewsomething commented Nov 22, 2022

bentranter left a comment •

edited

Loading

Revert "Support HTTP idle timeout & Project ID" #904

Revert "Support HTTP idle timeout & Project ID" #904

Conversation

andrewsomething commented Nov 22, 2022

bentranter left a comment • edited Loading

Choose a reason for hiding this comment

bentranter left a comment •

edited

Loading