Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apps: Support depoly on push to DOCR. #883

Merged
merged 2 commits into from
Sep 27, 2022
Merged

Conversation

andrewsomething
Copy link
Member

This is does not include an acceptance test. It is non-trivial to test as it requires interacting with Docker to build and push an image to a DOCR registry. I've tested this, but additional manual verification would be appreciated. Here's an example config:

resource "digitalocean_app" "docr-push-test" {
  spec {
    name = "docr-push-test"
    region = "nyc"

    service {
      name               = "docr-push-test"
      instance_count     = 1
      instance_size_slug = "basic-xxs"

      image {
        deploy_on_push {
          enabled = true
        }
        registry_type = "DOCR"
        repository    = "<image repository name>"
        tag           = "latest"
      }
    }
  }
}

@andrewsomething andrewsomething requested a review from a team September 23, 2022 22:25
@andrewsomething
Copy link
Member Author

As godo has added generics, the tests won't pass on 1.16 and 1.17. This will need to be merged first: #884

danaelhe
danaelhe previously approved these changes Sep 26, 2022
@andrewsomething andrewsomething merged commit 6014764 into main Sep 27, 2022
@andrewsomething andrewsomething deleted the asb/app-docr-push-deploy branch September 27, 2022 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants