Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SOA as possible record type #882

Merged
merged 1 commit into from
Sep 21, 2022
Merged

Conversation

Nosmoht
Copy link
Contributor

@Nosmoht Nosmoht commented Sep 21, 2022

Add SOA as possible record type.

Without it it's not possible to manage SOA records as the following error would be raised.

 Error: expected type to be one of [A AAAA CAA CNAME MX NS TXT SRV], got SOA

Add `SOA` as possible record type
@Nosmoht Nosmoht temporarily deployed to Acceptance Tests September 21, 2022 14:12 Inactive
@Nosmoht
Copy link
Contributor Author

Nosmoht commented Sep 21, 2022

Don't know what to do to make acceptance test green as it was canceled. Could someone please give me some advice?

Copy link
Member

@andrewsomething andrewsomething left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM, thanks for the contribution!

@andrewsomething andrewsomething merged commit 68a3322 into digitalocean:main Sep 21, 2022
@Nosmoht Nosmoht deleted the patch-1 branch September 26, 2022 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants