Suppress diffs on forced Redis version upgrades #873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scotchneat
requested review from
andrewsomething,
ChiefMateStarbuck and
danaelhe
|
May want to generalize the test |
|
I switched this to a Draft PR so I can look into integrating a call to the databases_list_operations endpoint to ensure the acceptance tests can update dynamically. |
Includes required update to godo dependency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To ensure customer Redis instances do not get destroyed and recreated after their Redis clusters are forced to upgrade, this change updates the
DiffSuppressFunclogic for Database Cluster resources to suppress diffs when the DB engine isredisandversionis newer on the remote resource than what is specified in the configuration.This should also help us avoid having to make this change for forced upgrades in the future.
for APICLI-1526