Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apps: Limit the number of deployments listed when polling. #865

Merged
merged 2 commits into from
Aug 16, 2022

Conversation

andrewsomething
Copy link
Member

This works around an issue with the App Platform API where the response body can be too large. We are only actually using the first deployment from the list, so we can use the default page size of 20 rather than 200 to prevent this. I've also removed the loop to prevent iterating through all deployments and using up API request quotas we only need the first one.

Fixes: #864

@andrewsomething andrewsomething requested a review from a team August 16, 2022 14:48
@andrewsomething andrewsomething temporarily deployed to Acceptance Tests August 16, 2022 14:50 Inactive
@andrewsomething andrewsomething temporarily deployed to Acceptance Tests August 16, 2022 15:20 Inactive
@andrewsomething andrewsomething merged commit 2cabf2b into main Aug 16, 2022
@andrewsomething andrewsomething deleted the asb/issues/864 branch August 16, 2022 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

terraform apply fails if digitalocean-api response gets to large
2 participants