Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change k8s example to use ingress v1 #837

Merged
merged 1 commit into from
Jun 15, 2022
Merged

Change k8s example to use ingress v1 #837

merged 1 commit into from
Jun 15, 2022

Conversation

jacobgreenleaf
Copy link
Contributor

@jacobgreenleaf jacobgreenleaf commented Jun 12, 2022

In Kubernetes 1.22, the v1beta1 version of Ingress
is no longer available, thus the example fails to create
the ingress on Kubernetes >= 1.22 with the following error:

╷
│ Error: Failed to create Ingress 'test/test-ingress' because: the server could not find the requested resource (post ingresses.extensions)
│ 
│   with module.kubernetes-config.kubernetes_ingress.test_ingress,
│   on kubernetes-config/main.tf line 126, in resource "kubernetes_ingress" "test_ingress":
│  126: resource "kubernetes_ingress" "test_ingress" {
│ 

Instead, switch the example to use kubernetes_ingress_v1.

Note that this now increases the minimum version of
terraform-provider-kubernetes since kubernetes_ingress_v1 was
added in v2.7.0.

In Kubernetes 1.22, the v1beta1 version of Ingress
is no longer available, thus the example fails to create
the ingress on Kubernetes >= 1.22. Switches the example
to use the kubernetes_ingress_v1 resource instead.

Note that this now increases the minimum version of
terraform-provider-kubernetes since kubernetes_ingress_v1 was
added in v2.7.0.
Copy link
Member

@andrewsomething andrewsomething left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM, thanks @jacobgreenleaf!

@andrewsomething andrewsomething merged commit 4a36d7d into digitalocean:main Jun 15, 2022
@MattIPv4
Copy link
Member

Hey, @jacobgreenleaf - Thanks a ton for this sweet PR! 😄

Would you please shoot me an email when you get a chance?
mcowley at digitalocean dot com 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants