Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vpc: Allow updating name and description of default vpcs. #748

Merged
merged 1 commit into from
Nov 12, 2021
Merged

vpc: Allow updating name and description of default vpcs. #748

merged 1 commit into from
Nov 12, 2021

Conversation

andrewsomething
Copy link
Member

@andrewsomething andrewsomething commented Nov 12, 2021 •
edited
Loading

The PUT request for updating a VPC needs to include the default attribute even if it is not changed in order to support updating the name or description of a region's default vpc.

Fixes: #747

@andrewsomething andrewsomething requested a review from a team November 12, 2021 15:27
@andrewsomething andrewsomething mentioned this pull request Nov 12, 2021
Closed
@andrewsomething andrewsomething temporarily deployed to Acceptance Tests November 12, 2021 15:29 Inactive
scotchneat
scotchneat approved these changes Nov 12, 2021
View reviewed changes
Copy link
Contributor

@scotchneat scotchneat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewsomething andrewsomething merged commit 7c5b9e6 into main Nov 12, 2021
@andrewsomething andrewsomething deleted the asb/issues/747 branch November 12, 2021 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scotchneat scotchneat scotchneat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot rename default vpc
2 participants
@andrewsomething @scotchneat