Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shutdown droplet #719

Merged
merged 4 commits into from
Oct 6, 2021
Merged

Conversation

scotchneat
Copy link
Contributor

Submitting this PR to get @gouyelliot 's changes from #658 merged with some extra fixes to an affected test.

From their PR:

Currently, the provider directly delete the droplet on a destroy or replace operation, which might result in a loss of data in some our apps.

I've added a simple param allowing to gracefully shutting down the droplet before deleting it.

@andrewsomething
Copy link
Member

Would be great to get a line added to the docs for this too https://github.com/digitalocean/terraform-provider-digitalocean/blob/main/docs/resources/droplet.md#argument-reference

Copy link
Member

@andrewsomething andrewsomething left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM!

@scotchneat scotchneat merged commit cd7d00a into digitalocean:main Oct 6, 2021
@scotchneat scotchneat deleted the shutdown-droplet branch October 6, 2021 21:57
atombrella pushed a commit to atombrella/terraform-provider-digitalocean that referenced this pull request Oct 10, 2021
* Add graceful_shutdown to droplet resource to properly shutdown droplet before destroying it

* Add test for graceful_shutdown on droplet resource

* Adds new attribute to ignore list.

* Update documentation and fix an issue with rebase

Co-authored-by: Elliot Gouy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants