Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apps: Make create timeout configurable (fixes: #628). #698

Merged
merged 4 commits into from
Sep 20, 2021
Merged

apps: Make create timeout configurable (fixes: #628). #698

merged 4 commits into from
Sep 20, 2021

Conversation

andrewsomething
Copy link
Member

Fixes: #628

@andrewsomething andrewsomething requested a review from a team September 15, 2021 20:03
scotchneat
scotchneat reviewed Sep 17, 2021
View reviewed changes
Copy link
Contributor

@scotchneat scotchneat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Is this something that could/should be noted in the provider docs?

@andrewsomething
Copy link
Member Author

@scotchneat Good call. Added a note to the docs for apps and other resources that support customized create timeouts.

scotchneat
scotchneat approved these changes Sep 20, 2021
View reviewed changes
Copy link
Contributor

@scotchneat scotchneat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. 👍🏽

@andrewsomething andrewsomething merged commit 0fe02bd into main Sep 20, 2021
@andrewsomething andrewsomething deleted the asb/issues/628 branch September 20, 2021 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scotchneat scotchneat scotchneat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DO Apps fail to due to the fixed timeout
2 participants
@andrewsomething @scotchneat