Update nginx example to work

[atombrella]

I couldn't see CoreOS in the list under the droplets anymore. Because the droplet is created with IPv6, I'd like to encourage people to support it better with a AAAA DNS record.

Please see #622

[atombrella]

@andrewsomething @scotchneat Let me know what more is needed to get this merged.

[scotchneat]

The change is great @atombrella!

This isn't a blocker but since the release of Terraform 0.12.14, Interpolation-only expressions are deprecated. This applies to the ${xxx} interpolation syntax within quotes but without any other text within the quotes.

Although it's still a warning, I think we could take this opportunity to address it. It can be resolved by removing the quotes. I included some suggestions inline but didn't cover all the instances. You can check if you still get the warning (as long as you're using terraform 0.12.14 or newer - I suggest >= 0.14) by running terraform plan on this example locally.

[atombrella]

@scotchneat Thanks :) The PR has been updated. My experience with Terraform is a bit limited, but I have used terraform plan and terraform apply before on some similar small setups in DigitalOcean.

Please adjust the commit message if needed. I couldn't really see a pattern for changes of this type.

[atombrella]

@scotchneat No warnings with tflint :) I won't make anymore changes to this PR.

[danaelhe]

@scotchneat No warnings with tflint :) I won't make anymore changes to this PR.

Looks great! I added a minor change to fix a lock issue I ran into. It's the same problem #595 addresses.

[scotchneat]

I'd love to merge the change as is since it covers the original purpose of the change.
However, there's one more change that would allow this example to run from a clean clone.

Currently, the ssh key is hardcoded to a specific key id. This will fail until the user updates the key. I've added some small suggestions inline that will make this dynamic and should allow users to run the example straight away.

[atombrella]

I'd love to merge the change as is since it covers the original purpose of the change.
However, there's one more change that would allow this example to run from a clean clone.

Currently, the ssh key is hardcoded to a specific key id. This will fail until the user updates the key. I've added some small suggestions inline that will make this dynamic and should allow users to run the example straight away.

OK. I was about to ask about this as well. Thanks! :)

[danaelhe]

lgtm! Thank you so much!

[scotchneat]

LGTM! Thanks again for the contribution

[MattIPv4]

Hey, @atombrella - Thanks a ton for this sweet PR! 😄

Would you please shoot me an email when you get a chance?
mcowley at digitalocean dot com 🎉