Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support distributing custom images to multiple regions. #616

Merged
merged 5 commits into from
Apr 19, 2021

Conversation

andrewsomething
Copy link
Member

When the digitalocean_custom_image resource was initially implemented, support for distributing images to more than one region was left as a TODO. This finishes it off. A few things to note:

  • An image can only be imported to a single region. It can be distributed to other regions when the initial import is complete.
  • DigitalOcean does not currently support removing/deleting an image from a region. So we must ForceNew if a region is removed from the list.

Copy link
Contributor

@scotchneat scotchneat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@andrewsomething andrewsomething merged commit 3e3f741 into main Apr 19, 2021
@andrewsomething andrewsomething deleted the asb/APICLI-646/multi-region-images branch April 19, 2021 21:03
andrewsomething added a commit that referenced this pull request Apr 26, 2021
* Rename files to match resource naming.

* Support creating custom image in multiple regions.

* Support transfering to additional regions on update.

* ForceNew when removing a region.

* Remove unnecessary sort.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants