Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

database cluster: Handle MongoDB password differences. #614

Merged
merged 2 commits into from
Apr 6, 2021
Merged

database cluster: Handle MongoDB password differences. #614

merged 2 commits into from
Apr 6, 2021

Conversation

andrewsomething
Copy link
Member

Support for the MongoDB beta.

MongoDB clusters only return their password in response to the initial POST. This means they need to be handled differently than other database clusters:

  • We need to set the password to state directly in the create function before doing any polling for status.
  • As the host for the cluster is not known until it becomes available, we must save the password and then add it to the URL returned latter to build a usable connection URI.

ChiefMateStarbuck
ChiefMateStarbuck approved these changes Apr 5, 2021
View reviewed changes
Copy link
Contributor

@ChiefMateStarbuck ChiefMateStarbuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome!

digitalocean/resource_digitalocean_database_cluster.go Show resolved Hide resolved
@andrewsomething andrewsomething merged commit 53b5263 into main Apr 6, 2021
@andrewsomething andrewsomething deleted the asb/mongodb branch April 6, 2021 18:47
andrewsomething added a commit that referenced this pull request Apr 26, 2021
@andrewsomething
database cluster: Handle MongoDB password differences. (#614)
5724c9f 
* database cluster: Handle MongoDB password differences.

* Use setDatabaseConnectionInfo in data source as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChiefMateStarbuck ChiefMateStarbuck ChiefMateStarbuck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andrewsomething @ChiefMateStarbuck