Adds support for kubernetes node pool taints #596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewsomething
previously requested changes
Mar 9, 2021
|
And here I was about to implement this in aybabtme@51e3dbd. Looking forward to this getting released! |
I've pushed my latest changes which address the requested changes
andrewsomething
requested changes
Mar 16, 2021
digitalocean/resource_digitalocean_kubernetes_node_pool_test.go
Outdated
Show resolved
Hide resolved
digitalocean/resource_digitalocean_kubernetes_node_pool_test.go
Outdated
Show resolved
Hide resolved
digitalocean/resource_digitalocean_kubernetes_node_pool_test.go
Outdated
Show resolved
Hide resolved
digitalocean/resource_digitalocean_kubernetes_node_pool_test.go
Outdated
Show resolved
Hide resolved
|
🥳 thanks for implementing this! |
andrewsomething
pushed a commit
that referenced
this pull request
Apr 26, 2021
* Adds support for kubernetes node pool taints * Address feedback and fix update logic * Address feedback and fix the failing cluster test * Removed commented lines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes some refactoring to allow schema reuse.
digitalocean/kubernetes.goThis allows the
taintsattribute to be exposed to both thekubernetes_clusterresource and datasource, as well as thekubernetes_node_poolresource.I'd like some feedback about the attribute name:
taint. Since this represents a list, I can see this being confusing and wanted to know how others feel about making this plural (would match the API also). Although, the singular tense makes the UI in terraform config files much clearer.closes #374