Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Firewall datasource #594

Merged
merged 7 commits into from
Mar 2, 2021
Merged

Adds Firewall datasource #594

merged 7 commits into from
Mar 2, 2021

Conversation

scotchneat
Copy link
Contributor

  • Moved the firewall schema to firewalls.go to share between the resource and datasource.
  • Added a test to create and update the datasource.
  • (unrelated) Removed -i flag from test make target since it's been deprecated (and caused failures locally)

Closes #188

andrewsomething
andrewsomething requested changes Mar 2, 2021
View reviewed changes
Copy link
Member

@andrewsomething andrewsomething left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

I made a few suggestions inline around making it so that both the name and id are not required for the data source.

We'll also need docs, but that can be a fast follow.

digitalocean/datasource_digitalocean_firewall_test.go Outdated Show resolved Hide resolved
digitalocean/datasource_digitalocean_firewall.go Outdated Show resolved Hide resolved
digitalocean/firewalls.go Show resolved Hide resolved
digitalocean/datasource_digitalocean_firewall_test.go Outdated Show resolved Hide resolved
digitalocean/firewalls.go Outdated Show resolved Hide resolved
andrewsomething
andrewsomething previously approved these changes Mar 2, 2021
View reviewed changes
Copy link
Member

@andrewsomething andrewsomething left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks great!

I did leave one suggestion about the docs inline.

docs/data-sources/firewall.md Outdated Show resolved Hide resolved
@andrewsomething andrewsomething self-requested a review March 2, 2021 17:56
andrewsomething
andrewsomething approved these changes Mar 2, 2021
View reviewed changes
Copy link
Member

@andrewsomething andrewsomething left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@scotchneat scotchneat merged commit 1f77729 into digitalocean:main Mar 2, 2021
@scotchneat scotchneat deleted the fw-datasource branch March 2, 2021 23:20
@scotchneat scotchneat mentioned this pull request Mar 3, 2021
Closed
andrewsomething pushed a commit that referenced this pull request Apr 26, 2021
@scotchneat @andrewsomething
Adds Firewall datasource (#594)
d3b55ce 
* Adds new firewall datasource

* Adds datasource test (not working)

* Fixes firewall datasource test

* Clean up

* Addresses suggestions from code review

* Remove optional/required attribute details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChiefMateStarbuck ChiefMateStarbuck ChiefMateStarbuck left review comments

@andrewsomething andrewsomething andrewsomething approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add digitalocean_firewall datasource
3 participants
@scotchneat @andrewsomething @ChiefMateStarbuck