Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix container registry creation and support updating subscription plans. #516

Merged
merged 3 commits into from
Nov 6, 2020

Conversation

andrewsomething
Copy link
Member

When registry support went into general availability, it added the requirement of specifying a subscription plan. This adds the subscription_tier_slug to both the resource and data source allowing it to be specified on create and updated.

$ make testacc TESTARGS=-run='ContainerRegistry'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run=ContainerRegistry -timeout 120m
?       github.com/digitalocean/terraform-provider-digitalocean [no test files]
=== RUN   TestAccDataSourceDigitalOceanContainerRegistry_Basic
=== PAUSE TestAccDataSourceDigitalOceanContainerRegistry_Basic
=== RUN   TestAccDigitalOceanContainerRegistry_importBasic
--- PASS: TestAccDigitalOceanContainerRegistry_importBasic (19.08s)
=== RUN   TestAccDigitalOceanContainerRegistryDockerCredentials_Basic
--- PASS: TestAccDigitalOceanContainerRegistryDockerCredentials_Basic (17.92s)
=== RUN   TestAccDigitalOceanContainerRegistryDockerCredentials_withExpiry
--- PASS: TestAccDigitalOceanContainerRegistryDockerCredentials_withExpiry (17.73s)
=== RUN   TestAccDigitalOceanContainerRegistry_Basic
--- PASS: TestAccDigitalOceanContainerRegistry_Basic (20.75s)
=== CONT  TestAccDataSourceDigitalOceanContainerRegistry_Basic
--- PASS: TestAccDataSourceDigitalOceanContainerRegistry_Basic (22.86s)
PASS
ok      github.com/digitalocean/terraform-provider-digitalocean/digitalocean    98.358s
testing: warning: no tests to run
PASS
ok      github.com/digitalocean/terraform-provider-digitalocean/internal/datalist       (cached) [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/digitalocean/terraform-provider-digitalocean/internal/setutil        (cached) [no tests to run]

Copy link
Member

@bentranter bentranter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants