Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port data sources and resources to use the context-related methods #503

Merged
merged 4 commits into from
Oct 19, 2020

Conversation

tdyas
Copy link
Contributor

@tdyas tdyas commented Oct 17, 2020

Port all of the data sources, resources, and datalist package to use the context-related resource functions (e.g., ReadContext etc.). The previous Read/Create/Update/Delete functions have been deprecated in SDK v2.

Copy link
Member

@andrewsomething andrewsomething left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM!

@andrewsomething andrewsomething merged commit 410de8b into digitalocean:master Oct 19, 2020
@andrewsomething
Copy link
Member

@tdyas Working with the new diag package, have you noticed any places we can be taking better advantage of it to return richer error messaging?

@tdyas
Copy link
Contributor Author

tdyas commented Oct 19, 2020

Working with the new diag package, have you noticed any places we can be taking better advantage of it to return richer error messaging?

It would be useful in resources where errors/warnings can be narrowed to particular attributes since each diag.Diagnostic can take the a "path steps slice" from the go-cty module to apply only to particular attributes.

@tdyas tdyas deleted the switch_to_context_methods branch October 19, 2020 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants