Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and extend acceptance test sweeper. #458

Merged
merged 5 commits into from
Oct 13, 2020
Merged

Fix and extend acceptance test sweeper. #458

merged 5 commits into from
Oct 13, 2020

Conversation

andrewsomething
Copy link
Member

@andrewsomething andrewsomething commented Jul 6, 2020

I noticed that the acceptance test sweeper has not been running. This was this was because it does not have access to the provider's DefaultFunc at runtime. In particular, DIGITALOCEAN_API_URL was not being correctly set.

This resolves that issue as well as adding sweepers for database clusters and Kubernetes clusters.

@ghost ghost added size/XS size/M and removed size/XS labels Jul 6, 2020
@andrewsomething andrewsomething changed the title Fix sweeper. Fix and extend acceptance test sweeper. Jul 7, 2020
Copy link
Contributor

@MasonEgger MasonEgger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants