Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force replacement if user tries to disable IPv6 on a droplet #1105

Merged
merged 3 commits into from
Feb 2, 2024

Conversation

danktec
Copy link
Contributor

@danktec danktec commented Jan 26, 2024

It appears the API does not support disablement of IPv6, only enablement. If ipv6 is set to false after being set to true then nothing changes on the cloud provider and the diff keeps happening forever #1104

This update uses forces a replacement if the user is trying to disable ipv6

Copy link
Member

@andrewsomething andrewsomething left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM!

Thanks for flagging this issue and the fix!

@andrewsomething andrewsomething merged commit 454dbdc into digitalocean:main Feb 2, 2024
2 checks passed
@danktec danktec changed the title Error out with a message if the user tries to disable IPv6 on a droplet Force replacement if user tries to disable IPv6 on a droplet Feb 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants