Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kafka topic + user ACL management doc fixes #1082

Merged
merged 2 commits into from
Nov 21, 2023
Merged

Kafka topic + user ACL management doc fixes #1082

merged 2 commits into from
Nov 21, 2023

Conversation

dweinshenker
Copy link
Contributor

@dweinshenker dweinshenker commented Nov 21, 2023 •
edited
Loading

What

  • Address default minimum for min_insync_replicas for topic advanced config
  • Address deprecated kafka plan
  • Update documentation

Why

When providing a topic's advanced config, we should enforce the default to be 1 for min_insync_replicas, even when it is not set. The default is in line with kafka defaults.

https://kafka.apache.org/documentation/#brokerconfigs_min.insync.replicas

Before

│ Error: Error creating database kafka topic: POST https://api.digitalocean.com/v2/databases/d75f23ac-41db-48f4-9364-33438fc5fe96/topics: 422 (request "4f8db04d-5c7a-4002-837c-5cc81b266999") invalid input for config 'min.insync.replicas': 0 is less than the minimum of 1

After

digitalocean_database_kafka_topic.foobar_topic_6: Creating...
digitalocean_database_kafka_topic.foobar_topic_6: Still creating... [10s elapsed]
digitalocean_database_kafka_topic.foobar_topic_6: Still creating... [20s elapsed]
digitalocean_database_kafka_topic.foobar_topic_6: Still creating... [30s elapsed]
digitalocean_database_kafka_topic.foobar_topic_6: Creation complete after 32s [id=d75f23ac-41db-48f4-9364-33438fc5fe96/topic/topic-6]

Testing

Ran TestAccDigitalOceanDatabaseUser_KafkaACLs and TestAccDigitalOceanDatabaseKafkaTopic acceptance tests to confirm results

@dweinshenker
Kafka topic + user management fixes
9fb91f9 
- Address minimum min_insync_replicas for topic advanced config
- Address deprecated kafka plan
- Update documentation
@dweinshenker dweinshenker changed the title Kafka topic + user management fixes Kafka topic + user ACL management doc fixes Nov 21, 2023
@dweinshenker dweinshenker marked this pull request as ready for review November 21, 2023 19:31
@danaelhe danaelhe merged commit 3fb1776 into digitalocean:main Nov 21, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danaelhe danaelhe danaelhe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dweinshenker @danaelhe