Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: added missing option to set port on health_check #1078

Merged
merged 3 commits into from
Nov 14, 2023
Merged

fix: added missing option to set port on health_check #1078

merged 3 commits into from
Nov 14, 2023

Conversation

nemcikjan
Copy link
Contributor

Fixes #1077

@danaelhe
Copy link
Member

danaelhe commented Nov 14, 2023 •
edited

🏃 That was quick! Awesome work- could you add a quick test in digitalocean/app/resource_app_test.go?

@danaelhe
Copy link
Member

And also docs in digitalocean/docs/resources/app.md - then it'll be ready to merge

@nemcikjan
Copy link
Contributor Author

@danaelhe added missing test and docs

danaelhe
danaelhe approved these changes Nov 14, 2023
View reviewed changes
Copy link
Member

@danaelhe danaelhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!! Thank you for the quick fix!

@danaelhe
Copy link
Member

Will cut a new release now, thanks again.

@danaelhe danaelhe merged commit 369127e into digitalocean:main Nov 14, 2023
2 checks passed
@andrewsomething andrewsomething mentioned this pull request Nov 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danaelhe danaelhe danaelhe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to set port for health_check
2 participants
@nemcikjan @danaelhe