Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apps: Add support for ingress for component routing, rewrites, and redirects. #1053

Merged
merged 5 commits into from
Oct 20, 2023

Conversation

andrewsomething
Copy link
Member

This PR adds support for app ingress rules for component routing, rewrites, cors, and redirects. Additionally, component level routes and cors have been deprecated in favor of the new top-level ingress. By doing so, we resolve the all current acceptance test failures for apps. The root of the failures was that while the apps API still accepts POSTs/PUTs with component level routes and cors, the responses/GETs convert them to ingress rules.

$ make testacc TESTARGS='-run=TestAccDigitalOceanApp'
=== RUN   TestAccDigitalOceanApp_importBasic
=== PAUSE TestAccDigitalOceanApp_importBasic
=== RUN   TestAccDigitalOceanApp_Image
=== PAUSE TestAccDigitalOceanApp_Image
=== RUN   TestAccDigitalOceanApp_Basic
=== PAUSE TestAccDigitalOceanApp_Basic
=== RUN   TestAccDigitalOceanApp_Job
=== PAUSE TestAccDigitalOceanApp_Job
=== RUN   TestAccDigitalOceanApp_StaticSite
=== PAUSE TestAccDigitalOceanApp_StaticSite
=== RUN   TestAccDigitalOceanApp_InternalPort
=== PAUSE TestAccDigitalOceanApp_InternalPort
=== RUN   TestAccDigitalOceanApp_Envs
=== PAUSE TestAccDigitalOceanApp_Envs
=== RUN   TestAccDigitalOceanApp_Worker
=== PAUSE TestAccDigitalOceanApp_Worker
=== RUN   TestAccDigitalOceanApp_Function
=== PAUSE TestAccDigitalOceanApp_Function
=== RUN   TestAccDigitalOceanApp_Domain
=== PAUSE TestAccDigitalOceanApp_Domain
=== RUN   TestAccDigitalOceanApp_DomainsDeprecation
=== PAUSE TestAccDigitalOceanApp_DomainsDeprecation
=== RUN   TestAccDigitalOceanApp_CORS
=== PAUSE TestAccDigitalOceanApp_CORS
=== RUN   TestAccDigitalOceanApp_TimeoutConfig
=== PAUSE TestAccDigitalOceanApp_TimeoutConfig
=== CONT  TestAccDigitalOceanApp_importBasic
=== CONT  TestAccDigitalOceanApp_Worker
--- PASS: TestAccDigitalOceanApp_importBasic (124.92s)
=== CONT  TestAccDigitalOceanApp_DomainsDeprecation
--- PASS: TestAccDigitalOceanApp_Worker (142.82s)
=== CONT  TestAccDigitalOceanApp_TimeoutConfig
--- PASS: TestAccDigitalOceanApp_TimeoutConfig (32.36s)
=== CONT  TestAccDigitalOceanApp_CORS
--- PASS: TestAccDigitalOceanApp_DomainsDeprecation (150.01s)
=== CONT  TestAccDigitalOceanApp_Domain
--- PASS: TestAccDigitalOceanApp_CORS (163.86s)
=== CONT  TestAccDigitalOceanApp_StaticSite
--- PASS: TestAccDigitalOceanApp_Domain (138.29s)
=== CONT  TestAccDigitalOceanApp_Envs
--- PASS: TestAccDigitalOceanApp_StaticSite (123.40s)
=== CONT  TestAccDigitalOceanApp_InternalPort
--- PASS: TestAccDigitalOceanApp_InternalPort (94.52s)
=== CONT  TestAccDigitalOceanApp_Function
--- PASS: TestAccDigitalOceanApp_Function (107.33s)
=== CONT  TestAccDigitalOceanApp_Basic
--- PASS: TestAccDigitalOceanApp_Envs (291.30s)
=== CONT  TestAccDigitalOceanApp_Job
--- PASS: TestAccDigitalOceanApp_Job (104.10s)
=== CONT  TestAccDigitalOceanApp_Image
--- PASS: TestAccDigitalOceanApp_Image (24.16s)
--- PASS: TestAccDigitalOceanApp_Basic (432.70s)
PASS
ok      github.com/digitalocean/terraform-provider-digitalocean/digitalocean/app        1097.098s

@andrewsomething andrewsomething requested a review from a team October 20, 2023 14:29
Copy link
Member

@danaelhe danaelhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@andrewsomething andrewsomething merged commit a54e98d into main Oct 20, 2023
2 checks passed
@andrewsomething andrewsomething deleted the asb/apps-ingress branch October 20, 2023 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants