Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LBAAS-2800: no region field needed for global lb type #1046

Merged
merged 5 commits into from
Oct 10, 2023
Merged

LBAAS-2800: no region field needed for global lb type #1046

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b086efc
updated region field for lb to be optional
apinonformoso Oct 9, 2023
eb1d597
added validation function for lb type field
apinonformoso Oct 9, 2023
e86cbb2
created lb custom diff function
apinonformoso Oct 9, 2023
bdaa2b5
renamed diff function
apinonformoso Oct 10, 2023
ab05ef0
added unit tests for loadbalancerDiffCheck function
apinonformoso Oct 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
created lb custom diff function
  • Loading branch information
@apinonformoso
apinonformoso committed Oct 9, 2023
commit e86cbb254b200547eacfb85b193838918f017436
27 changes: 27 additions & 0 deletions digitalocean/loadbalancer/resource_loadbalancer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,10 @@ func ResourceDigitalOceanLoadbalancer() *schema.Resource {
}
}

if err := loadbalancerDiffFunction(ctx, diff, v); err != nil {
return err
}

return nil
},
}
Expand Down Expand Up @@ -113,6 +117,29 @@ func resourceDigitalOceanLoadBalancerV1() map[string]*schema.Schema {
return loadBalancerV1Schema
}

func loadbalancerDiffFunction(ctx context.Context, d *schema.ResourceDiff, v interface{}) error {
typ, typSet := d.GetOk("type")
region, regionSet := d.GetOk("region")

if !typSet && !regionSet {
return fmt.Errorf("missing 'region' value")
}

typStr := typ.(string)
switch strings.ToUpper(typStr) {
case "GLOBAL":
if regionSet && region.(string) != "" {
return fmt.Errorf("'region' must be empty or not set when 'type' is '%s'", typStr)
}
case "REGIONAL":
if !regionSet || region.(string) == "" {
return fmt.Errorf("'region' must be set and not be empty when 'type' is '%s'", typStr)
}
}

return nil
}

func resourceDigitalOceanLoadBalancerV0() *schema.Resource {
return &schema.Resource{
Schema: map[string]*schema.Schema{
Expand Down
Loading