Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

database user: Remove unneeded GET request post-create. #1028

Merged
merged 2 commits into from
Sep 11, 2023

Conversation

andrewsomething
Copy link
Member

We have reports that the post-create GET requests can unexpectedly fail with a 404 at times despite the create succeeding. For the most part, this request is unnecessary. The information is returned in the POST response. This sets state with that information and removes the unnecessary GET.

=== RUN   TestAccDigitalOceanDatabaseUser_importBasic
=== PAUSE TestAccDigitalOceanDatabaseUser_importBasic
=== RUN   TestAccDigitalOceanDatabaseUser_Basic
=== PAUSE TestAccDigitalOceanDatabaseUser_Basic
=== RUN   TestAccDigitalOceanDatabaseUser_MongoDB
=== PAUSE TestAccDigitalOceanDatabaseUser_MongoDB
=== RUN   TestAccDigitalOceanDatabaseUser_MongoDBMultiUser
=== PAUSE TestAccDigitalOceanDatabaseUser_MongoDBMultiUser
=== RUN   TestAccDigitalOceanDatabaseUser_MySQLAuth
=== PAUSE TestAccDigitalOceanDatabaseUser_MySQLAuth
=== CONT  TestAccDigitalOceanDatabaseUser_importBasic
=== CONT  TestAccDigitalOceanDatabaseUser_MongoDBMultiUser
--- PASS: TestAccDigitalOceanDatabaseUser_importBasic (241.60s)
=== CONT  TestAccDigitalOceanDatabaseUser_MySQLAuth
--- PASS: TestAccDigitalOceanDatabaseUser_MongoDBMultiUser (515.28s)
=== CONT  TestAccDigitalOceanDatabaseUser_MongoDB
--- PASS: TestAccDigitalOceanDatabaseUser_MySQLAuth (286.26s)
=== CONT  TestAccDigitalOceanDatabaseUser_Basic
--- PASS: TestAccDigitalOceanDatabaseUser_Basic (245.87s)
--- PASS: TestAccDigitalOceanDatabaseUser_MongoDB (458.85s)
PASS
ok      github.com/digitalocean/terraform-provider-digitalocean/digitalocean/database   974.256s

@andrewsomething andrewsomething requested a review from a team September 8, 2023 20:03
Copy link
Member

@danaelhe danaelhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@andrewsomething andrewsomething merged commit de32434 into main Sep 11, 2023
2 checks passed
@andrewsomething andrewsomething deleted the asb/dbaas-users-unneeded-get branch September 11, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants