Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix gcm tag length truncation #845

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: fix gcm tag length truncation
  • Loading branch information
DasDingGehtNicht committed Feb 11, 2021
commit 7ce5ad1e78ad8c706539e787da2341f4f55df7cf
2 changes: 1 addition & 1 deletion lib/cipherModes.js
Original file line number Diff line number Diff line change
Expand Up @@ -756,7 +756,7 @@ modes.gcm.prototype.afterFinish = function(output, options) {
}

// trim tag to length
this.tag.truncate(this.tag.length() % (this._tagLength / 8));
this.tag.truncate(this.tag.length() - (this._tagLength / 8));

// check authentication tag
if(options.decrypt && this.tag.bytes() !== this._tag) {
Expand Down