support get info from an UTF-8 encode pem certificate #790
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to get info from a pem certificate whose Subject contains utf-8 encoded words(Chinese Simple), and I got unreadable codes.
This is caused by the method
_fromDer()
in/lib/ans1.js
, this method mismatch utf-8 encode words.I hava solve this problem, at least in Chinese Simple which encoded by utf-8.
I want to make a PR, also contains some test code in
/test/unit/utf8-pem.js
, please check it, thanks very much.