Asn1 validator node ed25519 #680

aljones15 · 2019-05-21T18:24:22Z

Adds:

ASN1 validators for der format ed25519 public and private keys
Adds the OID for ed25519 keys
Adds extract functions so node 12 ed25519 keys can be imported now.

dlongley · 2019-05-21T19:19:26Z

Some of the docs in here make it seem like the functions are specific to node.js buffers, etc. -- when they aren't. The docs can mention that if you're using node's API that the functions will be particularly helpful, but they should lead by saying that the functions, for example, convert a DER-formatted PKCS#8 private key to a raw private key.

We may also want the functions to be something like publicKeyFromDer() and publicKeyToDer() ... or something that more closely approximates existing the forge API. I think we need a short bikeshedding around. cc: @mattcollier, @davidlehn

lib/ed25519.js

tests/unit/ed25519.js

Co-Authored-By: David I. Lehn <[email protected]> Capitalize DER in unit test descriptions. Co-Authored-By: David I. Lehn <[email protected]> Uppercase DER in docs and tests.

lib/ed25519.js

mattcollier

Test suite is passing here and it's working well in crypto-ld. I'm happy with it.

Thank you @aljones15

aljones15 · 2019-07-17T23:14:02Z

@mattcollier sorry you had to change those consts but thanks for updating this.

dlongley

There a few simple changes we want here then I think we can merge.

lib/ed25519.js

mattcollier · 2019-07-18T14:11:21Z

@dlongley @aljones15 I'll handle Longley's comments.

Co-Authored-By: Dave Longley <[email protected]>

dlongley

I approve on the condition that the other changes I mentioned are applied.

Thanks!

lib/ed25519.js

mattcollier · 2019-07-18T15:45:34Z

@davidlehn I leave it to you to approve/merge and publish this. I'm not an owner on NPM. Thanks!

dlongley

Unfortunately, looking at this with @davidlehn has pointed out that this PR actually still needs work. I checked other APIs and we don't do publicKeyFromDer etc. We should not bake in specific buffer requirements when coming from DER since we have a bunch of other APIs that handle that stuff.

We need to change the publicKeyFromDer API to publicKeyFromAsn1 API (same for privateKey) and let the caller supply an ASN.1 object using our other APIs.

dlongley · 2019-07-18T19:21:41Z

lib/ed25519.js

+/**
+ * Takes in a public key exported in DER and returns the raw key value.
+ *
+ * @param {NativeBuffer} publicKeyBuffer - A DER formatted public key.


Any use of NativeBuffer in the docs should change -- this isn't a public name. It should be {Uint8Array|Buffer}. But, that being said -- we need to change this API to take in ASN.1 input anyway, not DER.

This actually is a jsdoc thing NativeBuffer here refers to a jsdoc type declared earlier in the file:

/** * NativeBuffer is either a Buffer or a Uint8Array. * @type {Buffer|Uint8Array} */

aljones15 · 2019-08-15T19:41:24Z

@dlongley @mattcollier this can be closed correct? another PR added this feature I believe.

dlongley · 2019-08-18T15:48:17Z

I don't know what the status is, but so we can better track it I'm linking to that other PR: #697.

davidlehn · 2019-09-05T02:51:42Z

#697 was merged and released causing conflicts here. If some of this patch should still be merged, please rebase and update as needed.

aljones15 · 2021-02-16T22:46:26Z

if I recall correctly this PR is not needed because it turns out the ed25519 keys use a common DER format that we already have a validator for. I believe this can be closed @dlongley

aljones15 requested review from davidlehn and dlongley May 21, 2019 18:24

aljones15 self-assigned this May 21, 2019

davidlehn reviewed May 22, 2019

View reviewed changes

lib/ed25519.js Outdated Show resolved Hide resolved

davidlehn reviewed May 22, 2019

View reviewed changes

lib/ed25519.js Outdated Show resolved Hide resolved

davidlehn reviewed May 22, 2019

View reviewed changes

lib/ed25519.js Outdated Show resolved Hide resolved

davidlehn reviewed May 22, 2019

View reviewed changes

tests/unit/ed25519.js Outdated Show resolved Hide resolved

aljones15 force-pushed the asn1-validator-node-ed25519 branch from f5b03bb to ce9cf21 Compare May 22, 2019 20:32

aljones15 requested a review from davidlehn June 18, 2019 17:47

aljones15 requested review from dmitrizagidulin, gannan08 and mattcollier July 16, 2019 16:40

aljones15 force-pushed the asn1-validator-node-ed25519 branch 2 times, most recently from 0cba333 to 00f1b3d Compare July 16, 2019 17:08

aljones15 added 15 commits July 17, 2019 11:48

Add validator types for node ed25519 keys.

394098b

Expose ed25519 validators on forge.

0a89e9e

Use consistent naming in validators for publicKey.

c916036

Add ability to extract from node ed25519 keys.

9ce48c2

Add 25519 OID to oids and check oid on import.

801ade2

Add tests for extract public and private key methods.

59eb431

Correct punctuation in jsdoc strings.

9032eb9

Correct code to pass webpack build.

658b2e7

Remove Buffer.from from tests so karma works.

35a860e

Rename ed25519 import methods so they do not mention node.

c6c47d8

Update docs to reflect a Buffer or Uint8Array can be used.

e647fc2

Refine the docs to and drop more mentions of node.

03c5c42

Use existing NativeBuffer type in docs.

953f64c

Uppercase DER in docs and tests.

dea079d

Co-Authored-By: David I. Lehn <[email protected]> Capitalize DER in unit test descriptions. Co-Authored-By: David I. Lehn <[email protected]> Uppercase DER in docs and tests.

Make documents more consistent.

a5739f5

mattcollier force-pushed the asn1-validator-node-ed25519 branch from 00f1b3d to a5739f5 Compare July 17, 2019 15:49

aljones15 commented Jul 17, 2019

View reviewed changes

lib/ed25519.js Outdated Show resolved Hide resolved

mattcollier mentioned this pull request Jul 17, 2019

Implement node v12 generate, sign and verify. digitalbazaar/crypto-ld#34

Merged

Use EdDSA25519 OID.

b552495

mattcollier force-pushed the asn1-validator-node-ed25519 branch from 6e427ca to 0ec3a2c Compare July 17, 2019 21:29

Style fixes.

114722c

mattcollier force-pushed the asn1-validator-node-ed25519 branch from c4a15cc to 114722c Compare July 17, 2019 22:04

Add .eslintrc.js for mocha.

6f177a3

mattcollier approved these changes Jul 17, 2019

View reviewed changes

dlongley requested changes Jul 18, 2019

View reviewed changes

lib/ed25519.js Outdated Show resolved Hide resolved

lib/ed25519.js Outdated Show resolved Hide resolved

lib/ed25519.js Outdated Show resolved Hide resolved

lib/ed25519.js Show resolved Hide resolved

lib/ed25519.js Outdated Show resolved Hide resolved

mattcollier and others added 3 commits July 18, 2019 10:14

Fix API documentation.

4fe8824

Co-Authored-By: Dave Longley <[email protected]>

Fix error messages.

acb1013

Make extractKey a private function.

658f4a5

mattcollier requested a review from dlongley July 18, 2019 14:30

dlongley approved these changes Jul 18, 2019

View reviewed changes

lib/ed25519.js Show resolved Hide resolved

lib/ed25519.js Outdated Show resolved Hide resolved

lib/ed25519.js Outdated Show resolved Hide resolved

lib/ed25519.js Outdated Show resolved Hide resolved

Fix documentation and exports.

40c7227

mattcollier force-pushed the asn1-validator-node-ed25519 branch from 569bb74 to 40c7227 Compare July 18, 2019 15:42

dlongley requested changes Jul 18, 2019

View reviewed changes

dlongley reviewed Jul 18, 2019

View reviewed changes

davidlehn added 2 commits July 18, 2019 15:25

Fix ASN.1 name usage.

d82d468

Fix typo.

aae1258

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Asn1 validator node ed25519 #680

Asn1 validator node ed25519 #680

aljones15 commented May 21, 2019

dlongley commented May 21, 2019

mattcollier left a comment

aljones15 commented Jul 17, 2019 •

edited

Loading

dlongley left a comment

mattcollier commented Jul 18, 2019

dlongley left a comment

mattcollier commented Jul 18, 2019

dlongley left a comment •

edited

Loading

dlongley Jul 18, 2019 •

edited

Loading

aljones15 Jul 18, 2019

aljones15 commented Aug 15, 2019

dlongley commented Aug 18, 2019

davidlehn commented Sep 5, 2019

aljones15 commented Feb 16, 2021

Asn1 validator node ed25519 #680

Are you sure you want to change the base?

Asn1 validator node ed25519 #680

Conversation

aljones15 commented May 21, 2019

dlongley commented May 21, 2019

mattcollier left a comment

Choose a reason for hiding this comment

aljones15 commented Jul 17, 2019 • edited Loading

dlongley left a comment

Choose a reason for hiding this comment

mattcollier commented Jul 18, 2019

dlongley left a comment

Choose a reason for hiding this comment

mattcollier commented Jul 18, 2019

dlongley left a comment • edited Loading

Choose a reason for hiding this comment

dlongley Jul 18, 2019 • edited Loading

Choose a reason for hiding this comment

aljones15 Jul 18, 2019

Choose a reason for hiding this comment

aljones15 commented Aug 15, 2019

dlongley commented Aug 18, 2019

davidlehn commented Sep 5, 2019

aljones15 commented Feb 16, 2021

aljones15 commented Jul 17, 2019 •

edited

Loading

dlongley left a comment •

edited

Loading

dlongley Jul 18, 2019 •

edited

Loading