TLS 1.2 implementation #534
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d() uses a correct check for TLS 1.2 based on the session.
…ls_final Conflicts: lib/tls.js
|
We've got some partial TLS 1.2 work done on the 0.8.x branch, for example this. We'll need to figure out what's in common and merge things. |
|
I confirm this work well without server requestCert。But It will hang after |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request consists of our implementation of TLS1.2 support, which we added for one of our projects. It supports two new cipher suites: TLS_RSA_WITH_AES_128_CBC_SHA256 and TLS_RSA_WITH_AES_256_CBC_SHA256. Tested against the unit test suite and openssl s_server with TLS 1.1 and TLS 1.2 forced, as well as examples/tls.js and examples/imap.js.