Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Providing explicit support for Groovy source code (fixes #13) #94

Merged
merged 20 commits into from
Apr 10, 2017
Merged

Providing explicit support for Groovy source code (fixes #13) #94

merged 20 commits into from
Apr 10, 2017

Commits on Mar 20, 2017

  1. Providing explicit support for Groovy source code (fixes #13)

    Supporting dedicated configuration for groovy source.
    The configuration allows access to formatter steps which have been introduced for Java, but which are also useable for Groovy code.
    Integrates Groovy-Eclipse based Groovy formatter step implementation.
    Allows coexistent configuration of Java and Groovy formatter steps.
    fvgh committed Mar 20, 2017
    Configuration menu
    Copy the full SHA
    952fe05 View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2017

  1. SkipFilesNamed's equality is based on its serialized representation. …

    …Set<String> has complicated serialization. Reused FileSignature.toSortedSet() for a more stable serialization.
    
    Also, using FileSignature.toSortedSet() without first calling asNonNulList() would be an error.  So, might as well have toSortedSet() call that method itself as its first argument.
    nedtwigg committed Apr 3, 2017
    Configuration menu
    Copy the full SHA
    9635398 View commit details
    Browse the repository at this point in the history
  2. Fixed some grammar and spelling errors in README. Also gave each sect…

    …ion its own invisible <a> tag for stable links.
    nedtwigg committed Apr 3, 2017
    Configuration menu
    Copy the full SHA
    0628870 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    dbfb2c3 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    115b987 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    c8377d1 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    97f06c3 View commit details
    Browse the repository at this point in the history
  7. Added a workaround for the new varargs ambiguity for GroovyExtension …

    …and SpotlessExtension. This means that Spotless can now use greclipse to format its gradle files.
    nedtwigg committed Apr 3, 2017
    Configuration menu
    Copy the full SHA
    196c29d View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2017

  1. Supporting dedicated configuration for groovy source.

    The configuration allows access to formatter steps which have been introduced for Java, but which are also useable for Groovy code.
    Integrates Groovy-Eclipse based Groovy formatter step implementation.
    Allows coexistent configuration of Java and Groovy formatter steps.
    fvgh committed Apr 5, 2017
    Configuration menu
    Copy the full SHA
    4eac44d View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2017

  1. Configuration menu
    Copy the full SHA
    b9c1358 View commit details
    Browse the repository at this point in the history
  2. Fixes according to review by @jbduncan (as far as possible, using the…

    … greclipse formatter)
    fvgh committed Apr 8, 2017
    Configuration menu
    Copy the full SHA
    4becbed View commit details
    Browse the repository at this point in the history
  3. 5 Configuration menu
    Copy the full SHA
    cdf45fc View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2017

  1. Fixed description/values of Groovy-Eclipse configuration example and …

    …expected formatter output.
    fvgh committed Apr 9, 2017
    Configuration menu
    Copy the full SHA
    25d57ad View commit details
    Browse the repository at this point in the history
  2. Make GroovyDefaultTargetTest platform independent. Focus on the subje…

    …ct to test. Omit implicit testing of end-line characters for licenseHeader step.
    fvgh committed Apr 9, 2017
    Configuration menu
    Copy the full SHA
    b24bf3f View commit details
    Browse the repository at this point in the history
  3. Changed excludeJava to use the same idiom we use for paddedCell().

    EXCLUDE_JAVA_DEFAULT was being used as an alias for `false`.  If we changed its value to true, it didn't just change the default behavior, it would also break the implementation logic.
    nedtwigg committed Apr 9, 2017
    Configuration menu
    Copy the full SHA
    8fd9a2f View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    cc69b88 View commit details
    Browse the repository at this point in the history
  5. Rather than copy-pasting JavaExtension.LICENSE_HEADER_DELIMITER, we c…

    …an reference it directly.
    nedtwigg committed Apr 9, 2017
    Configuration menu
    Copy the full SHA
    f6c1c7a View commit details
    Browse the repository at this point in the history
  6. Renamed greclipseFormat to just greclipse.

    The DSL should be based on the name of the project.  Many formatters have "format" in the name -> google-java-format, scalafmt, etc.  But others don't, e.g. ktlint.
    nedtwigg committed Apr 9, 2017
    Configuration menu
    Copy the full SHA
    d78a2b6 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    5a863b9 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    027892f View commit details
    Browse the repository at this point in the history