Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NPM tests #2225

Merged
merged 9 commits into from
Aug 25, 2024
Merged

Fix NPM tests #2225

merged 9 commits into from
Aug 25, 2024

Conversation

Goooler
Copy link
Member

@Goooler Goooler commented Aug 15, 2024

No description provided.

@Goooler Goooler marked this pull request as draft August 15, 2024 03:08
@nedtwigg
Copy link
Member

@simschla no action required, just an FYI. The xo style is behaving differently on dev machines vs CI. I'm not 100% sure what's happening, but I think it's something to do with version pinning. We put a fair amount of time into fixing it, but eventually just resorted to disabling / removing the xo tests. The js stuff still have plenty of coverage, keeping all the version of the js packages up to date would be a massive ongoing burden. So again, no action needed, just wanted to let you know.

@nedtwigg nedtwigg marked this pull request as ready for review August 25, 2024 16:52
@nedtwigg nedtwigg merged commit 0f2a4b6 into main Aug 25, 2024
28 checks passed
@nedtwigg nedtwigg deleted the fix-npm-tests branch August 25, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants