Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Java >= 9 #19

Merged
merged 6 commits into from
Nov 13, 2018
Merged

Add support for Java >= 9 #19

merged 6 commits into from
Nov 13, 2018

Conversation

ennerf
Copy link
Contributor

@ennerf ennerf commented Nov 13, 2018

This pull request adds compatibility for Jigsaw and fixes #16. Tested on JDK 9 / 10 / 11.

  • added a default Jigsaw module-name

  • replaced sun.misc.Cleaner workaround with Glue's multi-release jar

@ennerf
Copy link
Contributor Author

ennerf commented Nov 13, 2018

I'm not familiar with Travis. Is there a way to access file:https:///home/travis/build/diffplug/matfilerw/build/findbugs/main.html to see what rule violations it found?

@nedtwigg
Copy link
Member

If you run gradlew check on your machine, you can look at the build/findbugs/main.html on your own machine

@ennerf
Copy link
Contributor Author

ennerf commented Nov 13, 2018

Thanks. It was complaining about the manual System.gc() which has been in there for a while. Not sure how that got through the checks before.

I also ran into issues with the ProGuard-Maven plugin and MR-Jars, so I removed the dependency again and added a reflective version.

@nedtwigg
Copy link
Member

LGTM. Ready for me to merge and release?

@ennerf
Copy link
Contributor Author

ennerf commented Nov 13, 2018

Go for it

@nedtwigg nedtwigg merged commit 1a73e46 into diffplug:master Nov 13, 2018
@ennerf ennerf deleted the java9 branch November 13, 2018 18:44
@nedtwigg
Copy link
Member

Releases as 3.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Java 9 does not like MatFileReader#clean
2 participants